TranslateEventProto::DISABLED_BY_PREF are all logged without initializing the TranslateEventProto |
||
Issue descriptionBecause the TranslateEventProto (TEP) are not initialized before recording a DISABLED_BY_PREF, all logs report default values for the proto, including ranker_response= RankerResponse::SHOW (This is due to a bad choice of default value fur this enum). Initializing the TEP before recording the event would allow to log more useful information for these events, and log these as RankerResponse::NOT_QUERIED instead of SHOW.
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d834a40c4786172970684ea552ef40d4d3c6a28 commit 3d834a40c4786172970684ea552ef40d4d3c6a28 Author: Philippe Hamel <hamelphi@chromium.org> Date: Tue Aug 15 22:22:28 2017 Initialize TEP before recording DISABLED_BY_PREFS. Bug: 754350 Change-Id: Ib1b1525b21e493d74731b83a11998eab676e4abf Reviewed-on: https://chromium-review.googlesource.com/610890 Reviewed-by: Rachel Blum <groby@chromium.org> Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Cr-Commit-Position: refs/heads/master@{#494573} [modify] https://crrev.com/3d834a40c4786172970684ea552ef40d4d3c6a28/components/translate/core/browser/translate_manager.cc
,
Aug 16 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by hamelphi@chromium.org
, Aug 10 2017