Since PVer4 has now been fully rolled out, delete all PVer3 code. PVer4 has been in Stable (but enabled partially) since M58.
WIP CL: https://chromium-review.googlesource.com/#/c/chromium/src/+/689967 Deletes PVer3 from Chrome code, but not from tests. Tests do not compile yet.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03484499ff302c4ef5463477518ac95b74a03646 commit 03484499ff302c4ef5463477518ac95b74a03646 Author: Varun Khaneja <vakh@chromium.org> Date: Tue Aug 14 19:19:39 2018 Safe Browsing: Remove code for PVer3. It's time! PVer3 is the old specification of the protocol to download blacklist updates and query full hashes from the Safe Browsing service. PVer4 replaced this code in crbug.com/543161 Overall changes: * Replaced the use of SafeBrowsingProtocolConfig with V4ProtocolConfig. * Made TestSafeBrowsingService() the base class for a all derivatives of SafeBrowsingService in tests. * Add CanCreateDatabaseManager and CreateDatabaseManager in ServicesDelegate::ServicesCreator to allow tests to create their own DatabaseManager, if they choose to. TBR=tnagel TBR'ing tnagel since the changes in annotations.xml are trivial: just deleting lines for files being deleted. *************** Note to Sheriff *************** If this CL breaks any builds or any tests, please feel free to revert immediately. Reviewers, please review the changes in the following files: rdevlin.cronin: chrome/browser/extensions/ ntfschr: android_webview/browser/aw_safe_browsing_ui_manager.cc davidben: chrome/browser/net/trial_comparison_cert_verifier_unittest.cc, chrome/browser/prerender/prerender_test_utils.cc tnagel: tools/traffic_annotation/summary/annotations.xml qinmin: chrome/browser/download/download_browsertest.cc bbudge: chrome/test/ppapi/ppapi_filechooser_browsertest.cc Bug: 754341 Change-Id: I889dfe42848b8579e26aed0ea92c86b38fdfb87a Reviewed-on: https://chromium-review.googlesource.com/1153969 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#582991} [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/android_webview/browser/aw_safe_browsing_ui_manager.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/download/download_browsertest.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/extensions/blacklist_state_fetcher.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/extensions/blacklist_state_fetcher.h [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/extensions/fake_safe_browsing_database_manager.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/extensions/fake_safe_browsing_database_manager.h [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/extensions/test_blacklist_state_fetcher.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/net/trial_comparison_cert_verifier_unittest.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/prerender/prerender_test_utils.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/BUILD.gn [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/chunk.proto [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/chunk_range.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/chunk_range.h [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/chunk_range_unittest.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/client_side_model_loader.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/local_database_manager.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/local_database_manager.h [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/local_database_manager_unittest.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/protocol_manager.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/protocol_manager.h [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/protocol_manager_unittest.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/protocol_parser.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/protocol_parser.h [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/protocol_parser_unittest.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/safe_browsing_database.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/safe_browsing_database.h [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/safe_browsing_service.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/safe_browsing_service.h [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/safe_browsing_store.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/safe_browsing_store.h [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/safe_browsing_store_file.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/safe_browsing_store_file.h [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/safe_browsing_store_unittest.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/safe_browsing_util.cc [delete] https://crrev.com/68b4d2e190a0c62890099b7953bf26d9d131cebd/chrome/browser/safe_browsing/safe_browsing_util.h [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/services_delegate.h [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/services_delegate_impl.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/services_delegate_impl.h [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/services_delegate_stub.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/services_delegate_stub.h [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/test_safe_browsing_database_helper.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/test_safe_browsing_service.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/safe_browsing/test_safe_browsing_service.h [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/test/BUILD.gn [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/chrome/test/ppapi/ppapi_filechooser_browsertest.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/components/safe_browsing/BUILD.gn [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/components/safe_browsing/db/BUILD.gn [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/components/safe_browsing/db/database_manager.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/components/safe_browsing/db/database_manager.h [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/components/safe_browsing/db/v4_local_database_manager.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/components/safe_browsing/db/v4_local_database_manager.h [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/components/safe_browsing/db/v4_protocol_manager_util.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/components/safe_browsing/db/v4_protocol_manager_util.h [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/components/safe_browsing/ping_manager.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/components/safe_browsing/ping_manager.h [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/components/safe_browsing/ping_manager_unittest.cc [modify] https://crrev.com/03484499ff302c4ef5463477518ac95b74a03646/tools/traffic_annotation/summary/annotations.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/352ee5a7003e0699c82bf86d68be606fb82eb179 commit 352ee5a7003e0699c82bf86d68be606fb82eb179 Author: Varun Khaneja <vakh@chromium.org> Date: Tue Aug 28 18:31:42 2018 Restore annotations with 'deprecated' attribute set. Incorrectly deleted as part of http://crrev.com/c/1153969 Bug: 754341 Change-Id: I7f7fc998246a4ed1fd0b41c5168d37ff641105f9 Reviewed-on: https://chromium-review.googlesource.com/1192410 Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#586796} [modify] https://crrev.com/352ee5a7003e0699c82bf86d68be606fb82eb179/tools/traffic_annotation/summary/annotations.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52895b59189988f157c9fccb3a7aa7a50aa21f47 commit 52895b59189988f157c9fccb3a7aa7a50aa21f47 Author: Varun Khaneja <vakh@chromium.org> Date: Mon Sep 10 21:31:28 2018 Remove prefix_set.* as part of removing SafeBrowsing PVer3 protocol Bug: 754341 Change-Id: Ib8dcfcba25ea2f563365fca13f79873499639c52 Reviewed-on: https://chromium-review.googlesource.com/1211979 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#590070} [modify] https://crrev.com/52895b59189988f157c9fccb3a7aa7a50aa21f47/components/safe_browsing/db/BUILD.gn [delete] https://crrev.com/a223d9577eda9cd5501491a15bc8516862971e09/components/safe_browsing/db/prefix_set.cc [delete] https://crrev.com/a223d9577eda9cd5501491a15bc8516862971e09/components/safe_browsing/db/prefix_set.h [delete] https://crrev.com/a223d9577eda9cd5501491a15bc8516862971e09/components/safe_browsing/db/prefix_set_unittest.cc [modify] https://crrev.com/52895b59189988f157c9fccb3a7aa7a50aa21f47/tools/metrics/histograms/histograms.xml
Comment 1 by vakh@chromium.org
, Sep 28 2017