New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754327 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Remove sticky position dependency on layers in cc.

Project Member Reported by flackr@chromium.org, Aug 10 2017

Issue description

Related to  issue 709137 , we currently use layer ids in the position sticky constraint code to look up the nearest ancestor layer which shifts a sticky element. We should be using element ids to look up the transform nodes directly.
 

Comment 2 by flackr@chromium.org, Aug 10 2017

Labels: -Type-Bug Type-Task
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18b7cf40b592c76df40ddddb9c610c5f21c63289

commit 18b7cf40b592c76df40ddddb9c610c5f21c63289
Author: Robert Flack <flackr@chromium.org>
Date: Thu Aug 10 20:30:56 2017

Use element ids in cc sticky position code.

Replaces the use of layer ids with element ids on the sticky position cc side
ancestor node lookups and looks up the transform nodes directly instead of
going through the layers.

Bug:  754327 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I61f0d3889ce1ac92bcb190d9af3eba7a029b1a72
Reviewed-on: https://chromium-review.googlesource.com/610366
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Walter Korman <wkorman@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493519}
[modify] https://crrev.com/18b7cf40b592c76df40ddddb9c610c5f21c63289/cc/blink/web_layer_impl.cc
[modify] https://crrev.com/18b7cf40b592c76df40ddddb9c610c5f21c63289/cc/layers/layer_sticky_position_constraint.cc
[modify] https://crrev.com/18b7cf40b592c76df40ddddb9c610c5f21c63289/cc/layers/layer_sticky_position_constraint.h
[modify] https://crrev.com/18b7cf40b592c76df40ddddb9c610c5f21c63289/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/18b7cf40b592c76df40ddddb9c610c5f21c63289/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/18b7cf40b592c76df40ddddb9c610c5f21c63289/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/18b7cf40b592c76df40ddddb9c610c5f21c63289/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/18b7cf40b592c76df40ddddb9c610c5f21c63289/third_party/WebKit/public/platform/WebLayer.h
[modify] https://crrev.com/18b7cf40b592c76df40ddddb9c610c5f21c63289/third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h

Comment 4 by flackr@chromium.org, Aug 10 2017

Status: Fixed (was: Started)

Sign in to add a comment