New issue
Advanced search Search tips

Issue 754317 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove dead code related to log_parser/webkit_test_command.py

Project Member Reported by qyears...@chromium.org, Aug 10 2017

Issue description

This code was originally used for parsing layout test results. Things have changed, and it is now dead code.

Related code means:
 - build/scripts/master/log_parser/webkit_test_command.py
 - src/.../webkitpy/layout_tests/views/buildbot_results.py
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8925f01212c1c9e6ffdec9d842e957ffdeaf66c

commit c8925f01212c1c9e6ffdec9d842e957ffdeaf66c
Author: Quinten Yearsley <qyearsley@google.com>
Date: Fri Aug 11 00:16:03 2017

Don't print "WONTFIX" stats, and add TODO to remove more dead code.

Bug:  754317 
Change-Id: I414241b3414c43557c879be761ffc32e96413a65
Reviewed-on: https://chromium-review.googlesource.com/610465
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493609}
[modify] https://crrev.com/c8925f01212c1c9e6ffdec9d842e957ffdeaf66c/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c9e7b79922d2f7c8194e47f4ce903072bd9fec06

commit c9e7b79922d2f7c8194e47f4ce903072bd9fec06
Author: Quinten Yearsley <qyearsley@google.com>
Date: Sun Aug 13 20:19:53 2017

Remove log_parser/webkit_test_command.py

Reason: This now appears to be unused.

Bug:  754317 
Change-Id: I17865b7bdb262d41d5abcb6580e17b1f4d477538
Reviewed-on: https://chromium-review.googlesource.com/610508
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[delete] https://crrev.com/6644ac7b5dc4dac9b5bb2972bf46629f71b47f2b/scripts/master/log_parser/webkit_test_command.py
[modify] https://crrev.com/c9e7b79922d2f7c8194e47f4ce903072bd9fec06/scripts/master/factory/chromium_commands.py

Components: Blink>Infra
Labels: -OS-Linux
Status: Fixed (was: Assigned)

Sign in to add a comment