New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754302 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Aug 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

The more button should display a spinner when tapped with 0 suggestions

Project Member Reported by gambard@chromium.org, Aug 10 2017 
What steps will reproduce the problem?
(1) Open NTP with ContentSuggestions
(2) Dismiss all Articles until you see "That's all"
(3) Tap on "More"

What is the expected result?
A spinner should be displayed while the suggestions are fetched (same behavior as tapping "More" with at least one article).

What happens instead?
The "More" button is still tappable.

Comment 1 by fhorschig@chromium.org, Aug 11 2017

Labels: zine-triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/069a237796a9a12d9f483a7909e0b716c2a51d5e

commit 069a237796a9a12d9f483a7909e0b716c2a51d5e
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Aug 22 08:23:50 2017

Display spinner while a section is loading

When a section status is "loading", a spinner should be displayed in
its footer. When the status is no longer "loading", the spinner should
be removed.

Bug:  754302 
Change-Id: I43593459a471d766955a776657d3c212647b0bf3
Reviewed-on: https://chromium-review.googlesource.com/623208
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496250}
[modify] https://crrev.com/069a237796a9a12d9f483a7909e0b716c2a51d5e/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/069a237796a9a12d9f483a7909e0b716c2a51d5e/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_footer_item.h
[modify] https://crrev.com/069a237796a9a12d9f483a7909e0b716c2a51d5e/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_footer_item.mm
[modify] https://crrev.com/069a237796a9a12d9f483a7909e0b716c2a51d5e/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_footer_item_unittest.mm
[modify] https://crrev.com/069a237796a9a12d9f483a7909e0b716c2a51d5e/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/069a237796a9a12d9f483a7909e0b716c2a51d5e/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h

Comment 3 by gambard@chromium.org, Aug 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment