New issue
Advanced search Search tips

Issue 754294 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

goma_dir with a space doesn't work

Project Member Reported by gab@chromium.org, Aug 10 2017

Issue description

OS: Windows

use_goma = true
goma_dir = "C:\Users\gab\Google Drive\goma\goma-win64"

$ ninja -C out\Debug chrome

ninja: Entering directory `out\Debug'
[1/1] Regenerating ninja files
ninja: fatal: CreateProcess: %1 is not a valid Win32 application.


Moving goma_dir to "C:\goma\goma-win64" works. The space in "Google Drive" seems to be the issue.
 

Comment 2 by tikuta@chromium.org, Aug 14 2017

Components: -Infra>Goma

Comment 3 by tikuta@chromium.org, Aug 14 2017

Components: Build

Comment 4 by thakis@chromium.org, Aug 14 2017

ninja too supports this fine:

C:\src\chrome\src>type foo.cc
#include <stdio.h>
int main() {
  FILE* f = fopen("bar.txt", "wb");
  fprintf(f, "hello\n");
  fclose(f);
}

C:\src\chrome\src>cl /nologo foo.cc
foo.cc

C:\src\chrome\src>type build.ninja
rule gcc
  command = foo bar.exe

build foo.txt: gcc bar.txt


C:\src\chrome\src>type foo.txt
The system cannot find the file specified.

C:\src\chrome\src>ninja
[1/1] foo bar.exe

C:\src\chrome\src>type foo.txt
hello



gn probably doesn't escape this path quite right or something. In any case, doesn't seem super important. Goma likely isn't the only thing not handling spaces in directory names well.

Comment 5 by fly...@gmail.com, Nov 18 2017

Ninja has the problem. The project won't build at all if it lives in any path with spaces in OSX. Spaces in volume names are perfectly normal in the Mac world. 

[1/1] Regenerating ninja files
FAILED: build.ninja
/Volumes/Mac 2TB/Users/jjimenez/chromium/src/buildtools/mac/gn --root=/Volumes/Mac 2TB/Users/jjimenez/chromium/src -q gen .
/bin/sh: /Volumes/Mac: is a directory
ninja: error: rebuilding 'build.ninja': subcommand failed

Sign in to add a comment