New issue
Advanced search Search tips

Issue 754291 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 754289


Show other hotlists

Hotlists containing this issue:
Feature-Control-Code-Health


Sign in to add a comment

Make TouchEventFeatureDetectionForInspector a generic context-dependent feature

Project Member Reported by iclell...@chromium.org, Aug 10 2017

Issue description

TouchEventFeatureDetectionForInspector used to be a context-independent runtime-enabled feature (as 'TouchEventFeatureDetection'), and has recently been made an origin-trial-enabled feature in order to enable it for DevTools.

Once the generic context-dependent feature code is ready, this should be made into one, so that it does not act like an origin trial (Presently, tokens could be minted for this feature, and would be accepted by the origin trial context)
 
Cc: dgozman@chromium.org
Components: -Platform>DevTools

Comment 3 by cha...@chromium.org, Jun 21 2018

This could probably be changed to use the support for the [ContextEnabled] attribute. This is only used by "MojoJS" right now, but allows to programmatically turn on a feature and cause the bindings to be exposed. See usages of:
https://cs.chromium.org/chromium/src/third_party/blink/public/web/web_context_features.h?q=contextenabled&sq=package:chromium&dr=C&l=24

The point is that this maybe doesn't need to block on bug 754289.
I remember that [ContextEnabled] didn't work for this for some reason (i was considering using it). Maybe because we want it for all contexts in the frame? Or because we lacked some code-generation/control mechanism for turning it on/off when we needed? If this is possible to do now, it makes sense to switch over.

Sign in to add a comment