Files app Touch: Long-tap chooses both the item under pointer and keyboard/mouse focus |
||||||
Issue descriptionWhat steps will reproduce the problem? (1) Click on a file. See it turns blue. (single selection) (2) Long-press another file. What is the expected result? It enters the check-select mode. Only the second file is selected. What happens instead? It enters the check-select mode, but the both files are selected. This is similar to Issue 749137 , but in different code lines.
,
Aug 10 2017
,
Aug 10 2017
This is caused by not clearing existing selection. Will be fixed by https://chromium-review.googlesource.com/c/610341 simultaneously with the 2 other issues.
,
Aug 10 2017
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6b3ed78d0c53ca28e9959363132e9d8f4252933 commit e6b3ed78d0c53ca28e9959363132e9d8f4252933 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Tue Aug 15 10:33:06 2017 Reset selection and set the right lead index upon long-pressing. The lead index must be set so that commands referring it, like rename, can work successfully. This change also clears the selection before selecting the item, so as to make sure existing single selection (which is old lead item) will be cleared. Bug: 754272 , 754283 , 754290 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieb051b3b517cc06cd021d9b0feaa56c1e2a73b38 Reviewed-on: https://chromium-review.googlesource.com/610341 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#494354} [modify] https://crrev.com/e6b3ed78d0c53ca28e9959363132e9d8f4252933/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js
,
Aug 15 2017
Merge-request and review will be done on Issue 754283 which is fixed by the same change.
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f3bcd73e0f8c4250b245c3f83edc281d5186675 commit 2f3bcd73e0f8c4250b245c3f83edc281d5186675 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Aug 17 13:24:46 2017 Reset selection and set the right lead index upon long-pressing. The lead index must be set so that commands referring it, like rename, can work successfully. This change also clears the selection before selecting the item, so as to make sure existing single selection (which is old lead item) will be cleared. TBR=yamaguchi@chromium.org (cherry picked from commit e6b3ed78d0c53ca28e9959363132e9d8f4252933) Bug: 754272 , 754283 , 754290 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieb051b3b517cc06cd021d9b0feaa56c1e2a73b38 Reviewed-on: https://chromium-review.googlesource.com/610341 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#494354} Reviewed-on: https://chromium-review.googlesource.com/618830 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#628} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/2f3bcd73e0f8c4250b245c3f83edc281d5186675/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yamaguchi@chromium.org
, Aug 10 2017