HostCache uses TimeTicks for expiration |
|
Issue descriptionI noticed that HostCache uses TimeTicks for the record expiration (https://cs.chromium.org/chromium/src/net/dns/host_cache.h?q=HostCache&sq=package:chromium&l=121). However, according to the comment in the header that defines TimeTicks, its behavior varies by platform and may stop when the machine/device is suspended (https://cs.chromium.org/chromium/src/base/time/time.h?q=TimeTicks&sq=package:chromium&l=20). Its not clear that base::Time is strictly better either since it can change if the user resets their clock.
,
Aug 10 2017
It may even make sense to implement our own logic to try and fix TimeTicks to account for suspend mode ourselves. This no doubt affects a lot of other consumers as well.
,
Aug 11 2017
That is what I was thinking
,
Aug 11 2017
https://dev.chromium.org/developers/design-documents/sane-time and https://cs.chromium.org/chromium/src/components/network_time/network_time_tracker.h?l=52 are attempts to address a similar problem |
|
►
Sign in to add a comment |
|
Comment 1 by mmenke@chromium.org
, Aug 10 2017