New issue
Advanced search Search tips

Issue 754272 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 730232



Sign in to add a comment

Files app Touch: Cannot enter check-select by long-tapping on a single-selected item

Project Member Reported by yamaguchi@chromium.org, Aug 10 2017

Issue description

Chrome Version: 62.0.3182.0

Steps To Reproduce:
(1) Click on a file in the list. Confirm that the file turns blue (single selection).
(2) Press touchscreen on the file.

Expected Result:
It enters check-select mode. The checkbox of the file is checked (=selected state in the check-select mode).

Actual Result:
It stays in the normal mode. It shows a thumbnail for dragging.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

What is the impact to the user, and is there a workaround? If so, what is
it?
This will happen only when user combines other input devices than touchscreen or stylus. (i.e. keyboard or mouse)
This will affect next operation because it results in the different mode.
If user taps another item expecting to toggle-select it, it will actually open the item instead.
As a workaround, user can still long-press next item to enter the check-select mode, as there is a visual feedback whether it's in the check-select mode.
 
Description: Show this description
Description: Show this description
Description: Show this description
Status: Assigned (was: Unconfirmed)
Status: Started (was: Assigned)
This will be fixed by https://chromium-review.googlesource.com/c/610341
simultaneously with the 2 other issues.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6b3ed78d0c53ca28e9959363132e9d8f4252933

commit e6b3ed78d0c53ca28e9959363132e9d8f4252933
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Tue Aug 15 10:33:06 2017

Reset selection and set the right lead index upon long-pressing.

The lead index must be set so that commands referring it, like rename,
can work successfully.
This change also clears the selection before selecting the item, so as
to make sure existing single selection (which is old lead item) will
be cleared.

Bug:  754272 , 754283 , 754290 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieb051b3b517cc06cd021d9b0feaa56c1e2a73b38
Reviewed-on: https://chromium-review.googlesource.com/610341
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494354}
[modify] https://crrev.com/e6b3ed78d0c53ca28e9959363132e9d8f4252933/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js

Status: Fixed (was: Started)
Merge-request and review will be done on  Issue 754283  which is fixed by the same change.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 17 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f3bcd73e0f8c4250b245c3f83edc281d5186675

commit 2f3bcd73e0f8c4250b245c3f83edc281d5186675
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Thu Aug 17 13:24:46 2017

Reset selection and set the right lead index upon long-pressing.

The lead index must be set so that commands referring it, like rename,
can work successfully.
This change also clears the selection before selecting the item, so as
to make sure existing single selection (which is old lead item) will
be cleared.

TBR=yamaguchi@chromium.org

(cherry picked from commit e6b3ed78d0c53ca28e9959363132e9d8f4252933)

Bug:  754272 , 754283 , 754290 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieb051b3b517cc06cd021d9b0feaa56c1e2a73b38
Reviewed-on: https://chromium-review.googlesource.com/610341
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494354}
Reviewed-on: https://chromium-review.googlesource.com/618830
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#628}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/2f3bcd73e0f8c4250b245c3f83edc281d5186675/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment