New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754268 link

Starred by 2 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
ew...@chromium.org
bsazonov@chromium.org
kkaluri@chromium.org
msarda@chromium.org
jlebel@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

ugly popup after clicking "Remove this person"

Project Member Reported by vasi...@chromium.org, Aug 10 2017 
Chrome Version: 61.0.3163.31
OS: Linux

What steps will reproduce the problem?
(1) Click on the profile name in the top right corner
(2) Click "Manage people"
(3) Click on a profile and choose "Remove this person"

The popup looks extremely ugly. The text is rendered outside the popup.
Screenshot from 2017-08-10 15:51:40.png
80.1 KB View Download

Comment 1 by ew...@chromium.org, Aug 10 2017

Owner: dullweber@chromium.org
Christian, could this be related to the changes you made? Note that I can't reproduce this on Mac.

Comment 2 by bsazonov@chromium.org, Aug 17 2017

Owner: bsazonov@chromium.org
Status: Assigned (was: Untriaged)
I can consistently reproduce it on Linux on Chrome Stable 60.0.3112.101. The trick is a loooong email address.
Screenshot from 2017-08-17 17:19:29.png
171 KB View Download

Comment 3 by dullweber@chromium.org, Aug 17 2017 

Thanks for looking into this, my changes were submitted to M61.

Comment 4 by ew...@chromium.org, Aug 17 2017

Cc: msarda@chromium.org jlebel@chromium.org bsazonov@chromium.org
Owner: ----
Status: Available (was: Assigned)
Seems like another user manager polish bug to add to the list. Put it in our OKR list.

Comment 5 by msarda@chromium.org, Oct 6 2017

Owner: scottchen@chromium.org
Status: Assigned (was: Available)

Comment 6 by scottchen@chromium.org, Nov 1 2017

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd506daaf16930de723876f9080ec5dd5d1daee7

commit dd506daaf16930de723876f9080ec5dd5d1daee7
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Nov 03 11:43:03 2017

MD User Manager: fix broken-looking 'remove' dialog

Bug:  754268 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia746f7a546e221bf7ee3118d34fcc07008b23f7f
Reviewed-on: https://chromium-review.googlesource.com/749950
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513746}
[modify] https://crrev.com/dd506daaf16930de723876f9080ec5dd5d1daee7/chrome/browser/resources/md_user_manager/user_manager.html

Comment 8 by scottchen@chromium.org, Nov 3 2017

Status: Fixed (was: Started)

Comment 9 by kkaluri@chromium.org, Nov 6 2017

Cc: kkaluri@chromium.org
Labels: TE-Verified-M64 TE-Verified-64.0.3260.0
Verified this issue on Ubuntu 14.04 with chrome #64.0.3260.0 and observed that fix is working as expected.

Attaching the screen-cast for reference
754268.mp4
447 KB View Download
►

Sign in to add a comment