New issue
Advanced search Search tips

Issue 754226 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[Missing Tests]: Regression : Unwanted 'code syntax' is observed in error message dialog.

Project Member Reported by krajshree@chromium.org, Aug 10 2017

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
===
https://chromium.googlesource.com/chromium/src.git/+/b76712be975e258bbfc4ea62e6e2740064cc8f18

Ref Bug: 
========
https://bugs.chromium.org/p/chromium/issues/detail?id=751384

Thank you...!!
 
dschuyler@ Will you be able automate the test to avoid regressions in future?
#1 I've been kicking around ideas. Doing a 100% job of it doesn't look practical. And we're not able to easily do this kind of test afaik. One of the main sticking points is having some way to generate every webui page/route during testing.

crbug 747137 would also benefit from a way to iterate through webui pages. As would automated a11y testing; and some issues with i18n.

While there's not an easy solution right off, I think it's important to improve the automation of testing in these areas. 

(To be clear, it might not be too hard to test this one dialog to avoid regression on this one dialog, but imo that's not a good exchange of time for value -- e.g. I'd rather get a 1:1000 (which may be possible) than a 1:1 effort-to-value exchange).
Labels: -M-62 M-63

Comment 4 by ajha@chromium.org, Sep 19 2017

Labels: Needs-Feedback
Per C#2, is it fine to remove the blocker label here?
Labels: -Needs-Feedback -ReleaseBlock-Stable
#4 I think so.
Components: -Platform>DevTools
Labels: -Pri-1 -M-63 Pri-2
Components: UI>Settings
Owner: ----
Status: Untriaged (was: Assigned)
Status: WontFix (was: Untriaged)
I'm not sure if there is much to do here outside validating all the HTML? Closing this as WontFix.

Sign in to add a comment