New issue
Advanced search Search tips

Issue 754225 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Missing Tests]: MacViews single line textfields should scroll to the beginning when they lose focus

Project Member Reported by krajshree@chromium.org, Aug 10 2017

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
===
https://chromium.googlesource.com/chromium/src.git/+/fa2d40dd48636a51389970a21eb1dce68dd506b0

Ref Bug: 
========
https://bugs.chromium.org/p/chromium/issues/detail?id=657558

Thank you...!!
 
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/610424
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a4931c40e1badbdff6cb1e1e1fd2a8f0853ebd2

commit 4a4931c40e1badbdff6cb1e1e1fd2a8f0853ebd2
Author: Elly Fong-Jones <ellyjones@google.com>
Date: Thu Aug 10 17:28:20 2017

views: add unit test for textfield focus change behavior

This change adds a test for the Mac-specific behavior of textfields scrolling to
the start of their content when gaining or losing focus.

Bug:  754225 
Change-Id: Ib597ff70b996162d41dbf65c69a81eb8b0eb1b21
Reviewed-on: https://chromium-review.googlesource.com/610424
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493444}
[modify] https://crrev.com/4a4931c40e1badbdff6cb1e1e1fd2a8f0853ebd2/ui/views/controls/textfield/textfield_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment