https://chromium-review.googlesource.com/c/610421

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57ccb54fa33ab737f23399d7466f288c2de37ef5

commit 57ccb54fa33ab737f23399d7466f288c2de37ef5
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Mon Aug 14 17:07:17 2017

cocoa: add some browser window accessibility tests

More detailed thought is in order, but this will do for a start. These testts
validate that:

1) Every user-visible accessibility element has a role
2) Every user-visible accessibility element has descriptive text
3) The app menu button has the expected role (bug 754223)

Bug: 754223
Change-Id: I67c55df031ba67cfe240b56e3097c866885b4006
Reviewed-on: https://chromium-review.googlesource.com/610421
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494079}
[add] https://crrev.com/57ccb54fa33ab737f23399d7466f288c2de37ef5/chrome/browser/ui/cocoa/accessibility_browsertest.mm
[modify] https://crrev.com/57ccb54fa33ab737f23399d7466f288c2de37ef5/chrome/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/392ec01b9fac391251ab998b74fb5461218dbcc1

commit 392ec01b9fac391251ab998b74fb5461218dbcc1
Author: Reilly Grant <reillyg@chromium.org>
Date: Mon Aug 14 18:19:27 2017

Revert "cocoa: add some browser window accessibility tests"

This reverts commit 57ccb54fa33ab737f23399d7466f288c2de37ef5.

Reason for revert: Failing on Mac10.10 bot: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/22175

Original change's description:
> cocoa: add some browser window accessibility tests
> 
> More detailed thought is in order, but this will do for a start. These testts
> validate that:
> 
> 1) Every user-visible accessibility element has a role
> 2) Every user-visible accessibility element has descriptive text
> 3) The app menu button has the expected role (bug 754223)
> 
> Bug: 754223
> Change-Id: I67c55df031ba67cfe240b56e3097c866885b4006
> Reviewed-on: https://chromium-review.googlesource.com/610421
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494079}

TBR=ellyjones@chromium.org,sky@chromium.org,mark@chromium.org

Change-Id: I74f38eb8d255281e708487135e922bcf0e01dbd9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 754223
Reviewed-on: https://chromium-review.googlesource.com/614109
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494107}
[delete] https://crrev.com/647e94e090173cf7ac5d59d615d68dac166e5ae7/chrome/browser/ui/cocoa/accessibility_browsertest.mm
[modify] https://crrev.com/392ec01b9fac391251ab998b74fb5461218dbcc1/chrome/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d15b8aea034b3ee1d4d29b4953fa16812ac88af3

commit d15b8aea034b3ee1d4d29b4953fa16812ac88af3
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Wed Sep 20 20:50:03 2017

cocoa: add some browser window accessibility tests

More detailed thought is in order, but this will do for a start. These tests
validate that:

1) Every user-visible accessibility element has a role
2) Every user-visible accessibility element has descriptive text
3) The app menu button has the expected role (bug 754223)

Re-landing:
The original version of this change didn't work properly on macOS 10.10,
where some of the a11y properties that would be moved to NSButtonCell on
10.11 are still on NSButton. This version now decides dynamically which
of NSButton or NSButtonCell contains the needed properties. Icky.

Bug: 754223
Change-Id: Icf6dae0daa3225199441a4a9b96c2bf886efe246
Reviewed-on: https://chromium-review.googlesource.com/610421
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494079}
Reviewed-on: https://chromium-review.googlesource.com/626036
Cr-Commit-Position: refs/heads/master@{#503240}
[add] https://crrev.com/d15b8aea034b3ee1d4d29b4953fa16812ac88af3/chrome/browser/ui/cocoa/accessibility_browsertest.mm
[modify] https://crrev.com/d15b8aea034b3ee1d4d29b4953fa16812ac88af3/chrome/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2f8debe5bd9bfa4c888f025f41fe15ad13c04d9

commit b2f8debe5bd9bfa4c888f025f41fe15ad13c04d9
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Thu Sep 21 09:51:50 2017

Revert "cocoa: add some browser window accessibility tests"

This reverts commit d15b8aea034b3ee1d4d29b4953fa16812ac88af3.

Reason for revert: 
Tests AccessibilityTest.EveryElementHasRole
      AccessibilityTest.EveryElementHasText are failing on Mac 10.10 builder
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/23993

Original change's description:
> cocoa: add some browser window accessibility tests
> 
> More detailed thought is in order, but this will do for a start. These tests
> validate that:
> 
> 1) Every user-visible accessibility element has a role
> 2) Every user-visible accessibility element has descriptive text
> 3) The app menu button has the expected role (bug 754223)
> 
> Re-landing:
> The original version of this change didn't work properly on macOS 10.10,
> where some of the a11y properties that would be moved to NSButtonCell on
> 10.11 are still on NSButton. This version now decides dynamically which
> of NSButton or NSButtonCell contains the needed properties. Icky.
> 
> Bug: 754223
> Change-Id: Icf6dae0daa3225199441a4a9b96c2bf886efe246
> Reviewed-on: https://chromium-review.googlesource.com/610421
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#494079}
> Reviewed-on: https://chromium-review.googlesource.com/626036
> Cr-Commit-Position: refs/heads/master@{#503240}

TBR=ellyjones@chromium.org,sky@chromium.org,mark@chromium.org

Change-Id: I73731934cac0588e5a48263a9dd85116a043ae2e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 754223
Reviewed-on: https://chromium-review.googlesource.com/677243
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503405}
[delete] https://crrev.com/e56bcfa1d3d852362be9041a16b7768bbb583e4e/chrome/browser/ui/cocoa/accessibility_browsertest.mm
[modify] https://crrev.com/b2f8debe5bd9bfa4c888f025f41fe15ad13c04d9/chrome/test/BUILD.gn