external/wpt/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse-manual.html leak on WebKit Linux Trusty Leak |
||||
Issue descriptionFirst failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/7991 03:15:42.080 24222 worker/1 external/wpt/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse-manual.html leaked 03:15:42.080 24222 03:15:42.080 24222 DevTools listening on ws://127.0.0.1:49403/devtools/browser/b3e425df-160b-42f6-b5e2-130c20b17230 03:15:42.080 24222 Xlib: extension "RANDR" missing on display ":100". 03:15:42.083 3665 [3/4] external/wpt/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse-manual.html failed unexpectedly (leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,33],"numberOfLiveResources":[0,3],"numberOfLiveSuspendableObjects":[2,3]})) 03:15:42.081 24222 worker/1 external/wpt/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse-manual.html failed: 03:15:42.081 24222 worker/1 leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,33],"numberOfLiveResources":[0,3],"numberOfLiveSuspendableObjects":[2,3]})
,
Aug 10 2017
The only commit on the blame list: https://chromium-review.googlesource.com/c/609571 - reverting
,
Aug 10 2017
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d6d22736d0bee98b414a683b74f817c8400aa90 commit 3d6d22736d0bee98b414a683b74f817c8400aa90 Author: Olga Sharonova <olka@chromium.org> Date: Thu Aug 10 12:07:49 2017 Revert "Revert "Revert "Refactor the leak detector""" This reverts commit 15e35a0713b501df91fb6d4c6850e44c94f51907. Reason for revert: BUG= 754222 pointerevent_releasepointercapture_onpointerup_mouse-manual.html leak on WebKit Linux Trusty Leak Original change's description: > Revert "Revert "Refactor the leak detector"" > > This reverts commit de0372b3d86002ea729ce3fa518da6e2545eb5d8. > > Reason for revert: Fixed the suspicious change and now the leak should not happen > > Original change's description: > > Revert "Refactor the leak detector" > > > > This reverts commit 5e5e8213be42ee6690b030ea751c549f82e9b6b0. > > > > Reason for revert: seems to be causing the following test: > > > > external/wpt/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse-manual.html > > > > to fail with: > > > > ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,33],"numberOfLiveResources":[0,3],"numberOfLiveSuspendableObjects":[2,3]}) > > > > on https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/7876 > > > > Original change's description: > > > Refactor the leak detector > > > > > > > > > This CL is the first step to implement Real-world leak detector (design doc: https://docs.google.com/document/d/1wUWa7dWUdvr6dLdYHFfMQdnvgzt7lrrvzYfpAK-_6e0/edit?usp=sharing) > > > This refactors the existing leak detector code by creating a new class LeakDetector, so that the code could be reused in the real-world leak detector project. > > > > > > Bug: > > > Change-Id: I5bf519e1338fd52e4df34c6d0c2c5cd65f06933f > > > Reviewed-on: https://chromium-review.googlesource.com/589089 > > > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > > > Reviewed-by: Mike West <mkwst@chromium.org> > > > Reviewed-by: Peter Beverloo <peter@chromium.org> > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > > Reviewed-by: Keishi Hattori <keishi@chromium.org> > > > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#492582} > > > > TBR=sky@chromium.org,peter@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,keishi@chromium.org,yuzus@chromium.org,mkwst@chromium.org > > > > Change-Id: I66ddd3bc5edc4136f818276fb4de912e61a39b76 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/605448 > > Reviewed-by: John Mellor <johnme@chromium.org> > > Commit-Queue: John Mellor <johnme@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#492594} > > TBR=sky@chromium.org,johnme@chromium.org,peter@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,keishi@chromium.org,yuzus@chromium.org,mkwst@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I89cfc1a511944428c514a56bb1e6f21fc909707f > Reviewed-on: https://chromium-review.googlesource.com/609571 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuzu Saijo <yuzus@chromium.org> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/master@{#493344} TBR=sky@chromium.org,johnme@chromium.org,peter@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,keishi@chromium.org,yuzus@chromium.org,mkwst@chromium.org Change-Id: Iff4675057a6f3db8f9f71754554ccacd0a5bd8c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/610020 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#493362} [modify] https://crrev.com/3d6d22736d0bee98b414a683b74f817c8400aa90/content/public/test/render_view_test.cc [modify] https://crrev.com/3d6d22736d0bee98b414a683b74f817c8400aa90/content/shell/renderer/layout_test/blink_test_runner.cc [modify] https://crrev.com/3d6d22736d0bee98b414a683b74f817c8400aa90/content/shell/renderer/layout_test/leak_detector.cc [modify] https://crrev.com/3d6d22736d0bee98b414a683b74f817c8400aa90/content/shell/renderer/layout_test/leak_detector.h [modify] https://crrev.com/3d6d22736d0bee98b414a683b74f817c8400aa90/third_party/WebKit/Source/controller/BUILD.gn [delete] https://crrev.com/6e1c47762f26c9965c9093df8aefc1f84643e68c/third_party/WebKit/Source/controller/leak_detector/BlinkLeakDetector.cpp [delete] https://crrev.com/6e1c47762f26c9965c9093df8aefc1f84643e68c/third_party/WebKit/Source/controller/leak_detector/BlinkLeakDetector.h [delete] https://crrev.com/6e1c47762f26c9965c9093df8aefc1f84643e68c/third_party/WebKit/Source/controller/leak_detector/BlinkLeakDetectorClient.h [delete] https://crrev.com/6e1c47762f26c9965c9093df8aefc1f84643e68c/third_party/WebKit/Source/controller/leak_detector/README.md [delete] https://crrev.com/6e1c47762f26c9965c9093df8aefc1f84643e68c/third_party/WebKit/Source/controller/leak_detector/WebLeakDetector.cpp [modify] https://crrev.com/3d6d22736d0bee98b414a683b74f817c8400aa90/third_party/WebKit/Source/modules/exported/BUILD.gn [add] https://crrev.com/3d6d22736d0bee98b414a683b74f817c8400aa90/third_party/WebKit/Source/modules/exported/WebLeakDetector.cpp [modify] https://crrev.com/3d6d22736d0bee98b414a683b74f817c8400aa90/third_party/WebKit/public/web/WebLeakDetector.h
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc992ea5052f3f22dab815fc559991482ed9e31f commit dc992ea5052f3f22dab815fc559991482ed9e31f Author: Yuzu Saijo <yuzus@chromium.org> Date: Tue Aug 15 06:10:46 2017 Update LeakExpectaions to include pointerevent_releasepointercapture_onpointerup_mouse-manual.html It seems like there is a timing issue with this layout test, so this CL adds it to the leak expectation file. Bug: 754222 Change-Id: I72e0be9b4b6091ef9c726332c75f14a45d60954a Reviewed-on: https://chromium-review.googlesource.com/612035 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#494333} [modify] https://crrev.com/dc992ea5052f3f22dab815fc559991482ed9e31f/third_party/WebKit/LayoutTests/LeakExpectations
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aee19604c92edaee401c6edd57c546973a20a446 commit aee19604c92edaee401c6edd57c546973a20a446 Author: Yuzu Saijo <yuzus@chromium.org> Date: Tue Aug 15 09:41:11 2017 Revert "Revert "Revert "Revert "Refactor the leak detector"""" This reverts commit 3d6d22736d0bee98b414a683b74f817c8400aa90. Reason for revert: The failing layout test has a timing issue and it is added to LeakExpectaions. So this "Refactor the leak detector" CL should be able to safely land now. Original change's description: > Revert "Revert "Revert "Refactor the leak detector""" > > This reverts commit 15e35a0713b501df91fb6d4c6850e44c94f51907. > > Reason for revert: > BUG= 754222 > pointerevent_releasepointercapture_onpointerup_mouse-manual.html leak on WebKit Linux Trusty Leak > > Original change's description: > > Revert "Revert "Refactor the leak detector"" > > > > This reverts commit de0372b3d86002ea729ce3fa518da6e2545eb5d8. > > > > Reason for revert: Fixed the suspicious change and now the leak should not happen > > > > Original change's description: > > > Revert "Refactor the leak detector" > > > > > > This reverts commit 5e5e8213be42ee6690b030ea751c549f82e9b6b0. > > > > > > Reason for revert: seems to be causing the following test: > > > > > > external/wpt/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse-manual.html > > > > > > to fail with: > > > > > > ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,33],"numberOfLiveResources":[0,3],"numberOfLiveSuspendableObjects":[2,3]}) > > > > > > on https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/7876 > > > > > > Original change's description: > > > > Refactor the leak detector > > > > > > > > > > > > This CL is the first step to implement Real-world leak detector (design doc: https://docs.google.com/document/d/1wUWa7dWUdvr6dLdYHFfMQdnvgzt7lrrvzYfpAK-_6e0/edit?usp=sharing) > > > > This refactors the existing leak detector code by creating a new class LeakDetector, so that the code could be reused in the real-world leak detector project. > > > > > > > > Bug: > > > > Change-Id: I5bf519e1338fd52e4df34c6d0c2c5cd65f06933f > > > > Reviewed-on: https://chromium-review.googlesource.com/589089 > > > > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > > > > Reviewed-by: Mike West <mkwst@chromium.org> > > > > Reviewed-by: Peter Beverloo <peter@chromium.org> > > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > > > Reviewed-by: Keishi Hattori <keishi@chromium.org> > > > > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#492582} > > > > > > TBR=sky@chromium.org,peter@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,keishi@chromium.org,yuzus@chromium.org,mkwst@chromium.org > > > > > > Change-Id: I66ddd3bc5edc4136f818276fb4de912e61a39b76 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/605448 > > > Reviewed-by: John Mellor <johnme@chromium.org> > > > Commit-Queue: John Mellor <johnme@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#492594} > > > > TBR=sky@chromium.org,johnme@chromium.org,peter@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,keishi@chromium.org,yuzus@chromium.org,mkwst@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Change-Id: I89cfc1a511944428c514a56bb1e6f21fc909707f > > Reviewed-on: https://chromium-review.googlesource.com/609571 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Yuzu Saijo <yuzus@chromium.org> > > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#493344} > > TBR=sky@chromium.org,johnme@chromium.org,peter@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,keishi@chromium.org,yuzus@chromium.org,mkwst@chromium.org > > Change-Id: Iff4675057a6f3db8f9f71754554ccacd0a5bd8c7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/610020 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#493362} TBR=sky@chromium.org,johnme@chromium.org,peter@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,keishi@chromium.org,yuzus@chromium.org,olka@chromium.org,mkwst@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 754222 Change-Id: Icc5ebac7284b29e1e52a53241a59f2ab7d710772 Reviewed-on: https://chromium-review.googlesource.com/615220 Reviewed-by: Yuzu Saijo <yuzus@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#494351} [modify] https://crrev.com/aee19604c92edaee401c6edd57c546973a20a446/content/public/test/render_view_test.cc [modify] https://crrev.com/aee19604c92edaee401c6edd57c546973a20a446/content/shell/renderer/layout_test/blink_test_runner.cc [modify] https://crrev.com/aee19604c92edaee401c6edd57c546973a20a446/content/shell/renderer/layout_test/leak_detector.cc [modify] https://crrev.com/aee19604c92edaee401c6edd57c546973a20a446/content/shell/renderer/layout_test/leak_detector.h [modify] https://crrev.com/aee19604c92edaee401c6edd57c546973a20a446/third_party/WebKit/Source/controller/BUILD.gn [add] https://crrev.com/aee19604c92edaee401c6edd57c546973a20a446/third_party/WebKit/Source/controller/leak_detector/BlinkLeakDetector.cpp [add] https://crrev.com/aee19604c92edaee401c6edd57c546973a20a446/third_party/WebKit/Source/controller/leak_detector/BlinkLeakDetector.h [add] https://crrev.com/aee19604c92edaee401c6edd57c546973a20a446/third_party/WebKit/Source/controller/leak_detector/BlinkLeakDetectorClient.h [add] https://crrev.com/aee19604c92edaee401c6edd57c546973a20a446/third_party/WebKit/Source/controller/leak_detector/README.md [add] https://crrev.com/aee19604c92edaee401c6edd57c546973a20a446/third_party/WebKit/Source/controller/leak_detector/WebLeakDetector.cpp [modify] https://crrev.com/aee19604c92edaee401c6edd57c546973a20a446/third_party/WebKit/Source/modules/exported/BUILD.gn [delete] https://crrev.com/7a0aa1ec0d030c5adf09ea72178f93ca78d97bea/third_party/WebKit/Source/modules/exported/WebLeakDetector.cpp [modify] https://crrev.com/aee19604c92edaee401c6edd57c546973a20a446/third_party/WebKit/public/web/WebLeakDetector.h
,
Sep 27 2017
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4df121ac8463624c8af0a11e56605b1c5ee62165 commit 4df121ac8463624c8af0a11e56605b1c5ee62165 Author: Rune Lillesveen <rune@opera.com> Date: Wed Sep 27 13:44:35 2017 Missing return of Promise in automated pointerevents test. Bug: 754222 Change-Id: Ic0c906535182da26f13246248e34023a4a896b8e Reviewed-on: https://chromium-review.googlesource.com/686821 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#504649} [modify] https://crrev.com/4df121ac8463624c8af0a11e56605b1c5ee62165/third_party/WebKit/LayoutTests/LeakExpectations [modify] https://crrev.com/4df121ac8463624c8af0a11e56605b1c5ee62165/third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse-manual-automation.js
,
Sep 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by olka@chromium.org
, Aug 10 2017