New issue
Advanced search Search tips

Issue 754219 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Missing Tests]: [autofill] Type predictions not shown on query failure

Project Member Reported by krajshree@chromium.org, Aug 10 2017

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
===
https://chromium.googlesource.com/chromium/src.git/+/74251a06613acf413a5010eb1bbe0eab76bc32f8

Ref Bug: 
========
https://bugs.chromium.org/p/chromium/issues/detail?id=752225

Thank you...!!
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e0ec179730075b19ae6bd8c5a43a2e0219e42d3

commit 8e0ec179730075b19ae6bd8c5a43a2e0219e42d3
Author: Roger McFarlane <rogerm@chromium.org>
Date: Tue Aug 15 17:12:58 2017

[autofill] Add missing test.

To avoid regressions, adds a test to validate that when forms are
encountered, the type predictions are appropriately queue to be
sent to the renderer.

Note that this new test validates that the AutofillDriver's
SendAutofillTypePredictionsToRender is called appropriately by
the AutofillManager. It does not tests for the AutofillDriver's
imkplementation of the method.

BUG= 752225 , 754219 

Change-Id: I89a56af5949bffc6245f4bdfb608297fedcdca48
Reviewed-on: https://chromium-review.googlesource.com/615383
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: mahmadi (Moe) <mahmadi@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494422}
[modify] https://crrev.com/8e0ec179730075b19ae6bd8c5a43a2e0219e42d3/components/autofill/core/browser/autofill_manager_unittest.cc

Comment 2 by rogerm@chromium.org, Aug 15 2017

Status: Fixed (was: Assigned)

Sign in to add a comment