New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754212 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Minor tidy-ups Q3 2017

Project Member Reported by sjg@chromium.org, Aug 10 2017

Issue description

Tracking bug for small fixes and improvements.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9dfbc8845300d492324404f34fe288cecb525061

commit 9dfbc8845300d492324404f34fe288cecb525061
Author: Simon Glass <sjg@chromium.org>
Date: Thu Aug 10 19:59:34 2017

chromeos-config: Mark stable firmware as deprecated

This feature is being removed in M62. Mark the properties as deprecated so
it is clear that they are no-longer used.

BUG= chromium:705414 
BUG= chromium:754212 
TEST=check with 'retext README.md'
Signed-off-by: Simon Glass <sjg@chromium.org>

Change-Id: Ifa7a5897d45c7eb8ab929c64085d0ff75cdde185
Reviewed-on: https://chromium-review.googlesource.com/609941
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Commit-Queue: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/9dfbc8845300d492324404f34fe288cecb525061/chromeos-config/README.md

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c5dee8c4d65bbc0fc060cbc49a4db7dd8c9ecdf3

commit c5dee8c4d65bbc0fc060cbc49a4db7dd8c9ecdf3
Author: Simon Glass <sjg@chromium.org>
Date: Thu Aug 10 22:12:26 2017

chromeos-config: Fix up binding example so it compiles

There are a few errors in the example in the binding. Fix them so that the
example can be compiled. Future work will add a test for this.

BUG= chromium:754212 
TEST=awk 'BEGIN {print "/dts-v1/; / {" } END {print "};"} \
	/```/{flag = !flag; next} flag' README.md | dtc -
(adds a header and footer and compiles everything between ``` markers)

Change-Id: Ie28d52522f92eb299c8e570bfe1386ad65c847c7
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/609942
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/c5dee8c4d65bbc0fc060cbc49a4db7dd8c9ecdf3/chromeos-config/README.md

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b3eed1c88abf800de38b6af077f8a7cc637cbcf8

commit b3eed1c88abf800de38b6af077f8a7cc637cbcf8
Author: Simon Glass <sjg@chromium.org>
Date: Fri Aug 18 21:27:22 2017

dtc: Add a new patch for stdint

This was applied upstream and is needed to support using uint32_t in the
Python model.

BUG= chromium:754212 
TEST=emerge dtc; see that the patch is applied

Change-Id: I98abbe4b524b031c7c1f9d6a27a3a7ec072bb298
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/620826
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[rename] https://crrev.com/b3eed1c88abf800de38b6af077f8a7cc637cbcf8/sys-apps/dtc/dtc-1.4.4-r4.ebuild
[add] https://crrev.com/b3eed1c88abf800de38b6af077f8a7cc637cbcf8/sys-apps/dtc/files/0017-pylibfdt-Add-stdint-include-to-fix-uint32_t.patch

Comment 4 by sjg@chromium.org, Aug 18 2017

Cc: martinroth@chromium.org
Hi Martin, this is a test
got it.  Thanks.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/eb4a9f00b69929fab7a6637941b956544d94b82c

commit eb4a9f00b69929fab7a6637941b956544d94b82c
Author: Simon Glass <sjg@chromium.org>
Date: Wed Aug 23 13:08:35 2017

pack_firmware: Correct two pylint warnings

Fix the following warningsin pack_firmware_unittest:

C:155, 0: Wrong continued indentation.
C:476, 2: Variable args/keywords are named *args/**kwargs, not _

BUG= chromium:754212 
TEST=PYTHONPATH=~/cosarm python pack_firmware_unittest.py && \
PYTHONPATH=~/cosarm python pack_firmware_functest.py

Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I47d5449585a2d64641c211a8da7f63c26906fc71
Reviewed-on: https://chromium-review.googlesource.com/625691
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/eb4a9f00b69929fab7a6637941b956544d94b82c/pack_firmware_unittest.py

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 1 2017

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cf610f46dc596f74f4f12396ac15662ba7fac4a4

commit cf610f46dc596f74f4f12396ac15662ba7fac4a4
Author: Simon Glass <sjg@chromium.org>
Date: Sat Sep 02 00:56:19 2017

chromeos-config: Fix naming of 'reef' firmware node

This should be named 'reef' so that the model name is correct. Fix it and
update the binding to specify this.

Also fix another typo in the same section.

BUG= chromium:754212 
TEST=none
Change-Id: I848f2d1df794077d88b7c988bf6d02202c653080
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/646994
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/cf610f46dc596f74f4f12396ac15662ba7fac4a4/chromeos-config/README.md

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fdfececa6b02821c115890925f3a5564b81c1cf1

commit fdfececa6b02821c115890925f3a5564b81c1cf1
Author: Simon Glass <sjg@chromium.org>
Date: Wed Oct 04 00:22:43 2017

chromeos-config-tools: Update the config error message

With recent changes this is out of date. Update it to reflect the fact
that we have a dependency on chromeos-config-bsp.

BUG= chromium:754212 
TEST=none
Change-Id: I6f3c2eb9c9d7565787d457b89a71338e92497c75
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/688757
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[rename] https://crrev.com/fdfececa6b02821c115890925f3a5564b81c1cf1/chromeos-base/chromeos-config/chromeos-config-0.0.1-r3.ebuild
[modify] https://crrev.com/fdfececa6b02821c115890925f3a5564b81c1cf1/chromeos-base/chromeos-config/chromeos-config-0.0.1.ebuild

Comment 10 by sjg@chromium.org, Oct 9 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment