New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754196 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO Dec 22 - Jan 8
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

AudioRendererSinkCacheTest.NoGarbageCollectionForUsedSink flaky chromium.memory/Linux TSan Tests

Project Member Reported by olka@chromium.org, Aug 10 2017

Issue description

content_unittests mostly failing on chromium.memory/Linux TSan Tests

Builders failed on: 
- Linux TSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20TSan%20Tests


First failure https://uberchromegw.corp.google.com/p/chromium.memory/builders/Linux%20TSan%20Tests/builds/9973

LogDog : chromium/bb/chromium.memory/Linux_TSan_Tests/9973/+/recipes/steps/content_unittests/0/logs/AudioRendererSinkCacheTest.NoGarbageCollectionForUsedSink/0

 [ RUN      ] AudioRendererSinkCacheTest.NoGarbageCollectionForUsedSink
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: Stop()
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
../../content/renderer/media/audio_renderer_sink_cache_unittest.cc:243: Failure
      Expected: 1
To be equal to: sink_count()
      Which is: 0
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: Stop()
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
[  FAILED  ] AudioRendererSinkCacheTest.NoGarbageCollectionForUsedSink (1619 ms)
[ RUN      ] AudioRendererSinkCacheTest.NoGarbageCollectionForUsedSink
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: Stop()
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
../../content/renderer/media/audio_renderer_sink_cache_unittest.cc:243: Failure
      Expected: 1
To be equal to: sink_count()
      Which is: 0
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: Stop()
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
[  FAILED  ] AudioRendererSinkCacheTest.NoGarbageCollectionForUsedSink (1151 ms)
[ RUN      ] AudioRendererSinkCacheTest.NoGarbageCollectionForUsedSink
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: Stop()
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
../../content/renderer/media/audio_renderer_sink_cache_unittest.cc:243: Failure
      Expected: 1
To be equal to: sink_count()
      Which is: 0
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: Stop()
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
[  FAILED  ] AudioRendererSinkCacheTest.NoGarbageCollectionForUsedSink (1155 ms)
[ RUN      ] AudioRendererSinkCacheTest.NoGarbageCollectionForUsedSink
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: Stop()
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
../../content/renderer/media/audio_renderer_sink_cache_unittest.cc:243: Failure
      Expected: 1
To be equal to: sink_count()
      Which is: 0
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: Stop()
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
[  FAILED  ] AudioRendererSinkCacheTest.NoGarbageCollectionForUsedSink (1158 ms)


may be retated to https://chromium-review.googlesource.com/c/549520
 

Comment 1 by olka@chromium.org, Aug 10 2017

See also  Issue 753228 

Comment 3 by olka@chromium.org, Aug 10 2017

disabling so far, since I'm sheriffing and have no time to deal with it now https://chromium-review.googlesource.com/c/610043
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb72d9005c37bb3f417a6dd1be71150c0a287d59

commit bb72d9005c37bb3f417a6dd1be71150c0a287d59
Author: Olga Sharonova <olka@chromium.org>
Date: Thu Aug 10 12:49:59 2017

Disabling flaky AudioRendererSinkCacheTest.NoGarbageCollectionForUsedSink

TBR=dalecurtis@chromium.org

Bug:  754196 
Change-Id: I3904ff598fa9d584f472207c981a24027581e8e4
Reviewed-on: https://chromium-review.googlesource.com/610043
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493365}
[modify] https://crrev.com/bb72d9005c37bb3f417a6dd1be71150c0a287d59/content/renderer/media/audio_renderer_sink_cache_unittest.cc

Comment 5 by olka@chromium.org, Aug 10 2017

Labels: -Sheriff-Chromium
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38a2182ecf39ecc2b428a7208fa4de159934b713

commit 38a2182ecf39ecc2b428a7208fa4de159934b713
Author: Olga Sharonova <olka@chromium.org>
Date: Mon Aug 28 08:20:24 2017

Move thread initialization to the beginning of AudioRendererSinkCacheTest* tests

So that it does not affect timing on TSan bots.

TBR=miu@chromium.org

Bug:  754196 
Change-Id: Ie48a59f7d843f2be32f0be93ee30de8122fe2638
Reviewed-on: https://chromium-review.googlesource.com/637306
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497709}
[modify] https://crrev.com/38a2182ecf39ecc2b428a7208fa4de159934b713/content/renderer/media/audio_renderer_sink_cache_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87e7bdec5fba727cffdfc9420a02433c506dfea0

commit 87e7bdec5fba727cffdfc9420a02433c506dfea0
Author: Olga Sharonova <olka@chromium.org>
Date: Mon Aug 28 09:18:48 2017

Revert "Disabling flaky AudioRendererSinkCacheTest.NoGarbageCollectionForUsedSink"

This reverts commit bb72d9005c37bb3f417a6dd1be71150c0a287d59.

Reason for revert: speculative fix landed https://chromium.googlesource.com/chromium/src.git/+/38a2182ecf39ecc2b428a7208fa4de159934b713
BUG:  754196 
TBR=miu@chromium.org

Original change's description:
> Disabling flaky AudioRendererSinkCacheTest.NoGarbageCollectionForUsedSink
> 
> TBR=dalecurtis@chromium.org
> 
> Bug:  754196 
> Change-Id: I3904ff598fa9d584f472207c981a24027581e8e4
> Reviewed-on: https://chromium-review.googlesource.com/610043
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Commit-Queue: Olga Sharonova <olka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#493365}

TBR=dalecurtis@chromium.org,olka@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  754196 
Change-Id: I71dba450da3e56da5f81ef2ec4a90ff21e5769d1
Reviewed-on: https://chromium-review.googlesource.com/636245
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497724}
[modify] https://crrev.com/87e7bdec5fba727cffdfc9420a02433c506dfea0/content/renderer/media/audio_renderer_sink_cache_unittest.cc

Comment 8 by olka@chromium.org, Aug 29 2017

Status: Fixed (was: Assigned)
TSan has been green, marking as fixed.

Sign in to add a comment