* Update the message * Update the illustration to have a white background
* Update the message * Update the illustration to have a white background * Remove status card in favor of immediately showing the all dismissed state
The "all dismissed" illustration currently has a grey background. We need a version with a white (or transparent?) background.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c160a08f8b2161039e48dca188bcf3a633084c9c commit c160a08f8b2161039e48dca188bcf3a633084c9c Author: Bernhard Bauer <bauerb@chromium.org> Date: Mon Aug 21 16:16:41 2017 [Chrome Home Modern] Show "all dismissed" when the last article is dismissed. Never show the status card, and show the "all dismissed" state as soon as the last article is dismissed. Also remove the refresh button from the "all dismissed" UI. UI catalogue screenshot: https://goo.gl/photos/yv9pb7P2AeBU2mMVA Bug: 754194 Change-Id: I4344e50b5ee12cbe7b32fe032cdc3611834bd167 Reviewed-on: https://chromium-review.googlesource.com/610234 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#495952} [modify] https://crrev.com/c160a08f8b2161039e48dca188bcf3a633084c9c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java [modify] https://crrev.com/c160a08f8b2161039e48dca188bcf3a633084c9c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/c160a08f8b2161039e48dca188bcf3a633084c9c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java [modify] https://crrev.com/c160a08f8b2161039e48dca188bcf3a633084c9c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/c160a08f8b2161039e48dca188bcf3a633084c9c/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/HomeSheetUiCaptureTest.java [modify] https://crrev.com/c160a08f8b2161039e48dca188bcf3a633084c9c/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/c160a08f8b2161039e48dca188bcf3a633084c9c/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java [modify] https://crrev.com/c160a08f8b2161039e48dca188bcf3a633084c9c/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java [modify] https://crrev.com/c160a08f8b2161039e48dca188bcf3a633084c9c/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java
Let's bring this to the UX sync today.
Update from Rachel: She has the asset and will come back to you soon.
Bernhard, Rachel, is this on track to complete before branch point on 31 August?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f commit 2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f Author: Bernhard Bauer <bauerb@chromium.org> Date: Thu Aug 31 23:22:16 2017 Update "all dismissed" UI for Chrome Home Modern. Add a new illustration with a white background (sigh), rename the old one to ..._gray, and update the text. Screenshot: https://goo.gl/photos/DQWHs1W26dF57fgKA Bug: 754194 Change-Id: Iecd6684b6e1f485f1cbca0bb96cbb8b6843be4dc Reviewed-on: https://chromium-review.googlesource.com/645808 Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#499068} [rename] https://crrev.com/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f/chrome/android/java/res/drawable-hdpi/ntp_all_dismissed_gray.webp [add] https://crrev.com/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f/chrome/android/java/res/drawable-hdpi/ntp_all_dismissed_white.webp [rename] https://crrev.com/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f/chrome/android/java/res/drawable-mdpi/ntp_all_dismissed_gray.webp [add] https://crrev.com/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f/chrome/android/java/res/drawable-mdpi/ntp_all_dismissed_white.webp [rename] https://crrev.com/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f/chrome/android/java/res/drawable-xhdpi/ntp_all_dismissed_gray.webp [add] https://crrev.com/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f/chrome/android/java/res/drawable-xhdpi/ntp_all_dismissed_white.webp [rename] https://crrev.com/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f/chrome/android/java/res/drawable-xxhdpi/ntp_all_dismissed_gray.webp [add] https://crrev.com/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f/chrome/android/java/res/drawable-xxhdpi/ntp_all_dismissed_white.webp [rename] https://crrev.com/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f/chrome/android/java/res/drawable-xxxhdpi/ntp_all_dismissed_gray.webp [add] https://crrev.com/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f/chrome/android/java/res/drawable-xxxhdpi/ntp_all_dismissed_white.webp [modify] https://crrev.com/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f/chrome/android/java/res/layout/new_tab_page_all_dismissed.xml [modify] https://crrev.com/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java [modify] https://crrev.com/2a3de6795bf6ee9e3dae2313991c8b86f6a7f06f/chrome/android/java/strings/android_chrome_strings.grd
Comment 1 by bauerb@chromium.org
, Aug 10 2017