Update the sign-in promo in content suggestions to the modern style and move it to the top of the feed.
Preview attached (Tate-generated)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70c937134d62aa896d8b891673d475233d9c122d commit 70c937134d62aa896d8b891673d475233d9c122d Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Tue Aug 15 12:39:28 2017 [Suggestions] Add modern styles for sign in promo Adds styles to be used for modern cards and uses them in the existing one and for the new style of sign in promo. Additionally, sign in promos are now at the top in Modern. Preview: https://goo.gl/photos/QjeWSHMtphWKpBebA Bug: 754186 Change-Id: I58600912a0c39385a502c7daaaf37cc614f882ab Reviewed-on: https://chromium-review.googlesource.com/611905 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#494365} [modify] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/android/java/res/layout/content_suggestions_card_modern.xml [add] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/android/java/res/layout/content_suggestions_status_card_modern.xml [modify] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java [modify] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java [modify] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/android/java_sources.gni [modify] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NtpUiCaptureTestData.java [modify] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [add] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/HomeSheetEmptyUiCaptureTest.java [modify] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/ContentSuggestionsTestUtils.java [add] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-signin_promo.Nexus_5-19.png [add] https://crrev.com/70c937134d62aa896d8b891673d475233d9c122d/chrome/test/data/android/render_tests/ArticleSnippetsTest.signin_promo.Nexus_5-19.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d5969087674579defcb364d39e8b2222555c957 commit 1d5969087674579defcb364d39e8b2222555c957 Author: Reilly Grant <reillyg@chromium.org> Date: Tue Aug 15 20:14:18 2017 Revert "[Suggestions] Add modern styles for sign in promo" This reverts commit 70c937134d62aa896d8b891673d475233d9c122d. Reason for revert: Render tests are failing with this change: org.chromium.chrome.browser.ntp.snippets.ArticleSnippetsTest#testSnippetAppearance with --enable-features=ChromeHomeModernLayout org.chromium.chrome.browser.ntp.snippets.ArticleSnippetsTest#testSigninPromo with --enable-features=ChromeHomeModernLayout org.chromium.chrome.browser.suggestions.HomeSheetEmptyUiCaptureTest#testSignInPromo with --enable-features=ChromeHomeModernLayout,ChromeHome https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44798 Original change's description: > [Suggestions] Add modern styles for sign in promo > > Adds styles to be used for modern cards and uses them in the > existing one and for the new style of sign in promo. Additionally, > sign in promos are now at the top in Modern. > > Preview: > https://goo.gl/photos/QjeWSHMtphWKpBebA > > Bug: 754186 > Change-Id: I58600912a0c39385a502c7daaaf37cc614f882ab > Reviewed-on: https://chromium-review.googlesource.com/611905 > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#494365} TBR=bauerb@chromium.org,dgn@chromium.org Change-Id: If139f1a0aa1e586370082d79b64b06ca1b2c9732 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754186 Reviewed-on: https://chromium-review.googlesource.com/615924 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#494519} [modify] https://crrev.com/1d5969087674579defcb364d39e8b2222555c957/chrome/android/java/res/layout/content_suggestions_card_modern.xml [delete] https://crrev.com/9903668c3999d97f94534a85f53444f43a738382/chrome/android/java/res/layout/content_suggestions_status_card_modern.xml [modify] https://crrev.com/1d5969087674579defcb364d39e8b2222555c957/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/1d5969087674579defcb364d39e8b2222555c957/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/1d5969087674579defcb364d39e8b2222555c957/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java [modify] https://crrev.com/1d5969087674579defcb364d39e8b2222555c957/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java [modify] https://crrev.com/1d5969087674579defcb364d39e8b2222555c957/chrome/android/java_sources.gni [modify] https://crrev.com/1d5969087674579defcb364d39e8b2222555c957/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NtpUiCaptureTestData.java [modify] https://crrev.com/1d5969087674579defcb364d39e8b2222555c957/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [delete] https://crrev.com/9903668c3999d97f94534a85f53444f43a738382/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/HomeSheetEmptyUiCaptureTest.java [modify] https://crrev.com/1d5969087674579defcb364d39e8b2222555c957/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/1d5969087674579defcb364d39e8b2222555c957/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/ContentSuggestionsTestUtils.java [delete] https://crrev.com/9903668c3999d97f94534a85f53444f43a738382/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-signin_promo.Nexus_5-19.png [delete] https://crrev.com/9903668c3999d97f94534a85f53444f43a738382/chrome/test/data/android/render_tests/ArticleSnippetsTest.signin_promo.Nexus_5-19.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50141f191674e2e1654259b35eb7070b43b99ee0 commit 50141f191674e2e1654259b35eb7070b43b99ee0 Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Wed Aug 16 14:19:44 2017 Reland "[Suggestions] Add modern styles for sign in promo" This is a reland of 70c937134d62aa896d8b891673d475233d9c122d Original change's description: > [Suggestions] Add modern styles for sign in promo > > Adds styles to be used for modern cards and uses them in the > existing one and for the new style of sign in promo. Additionally, > sign in promos are now at the top in Modern. > > Preview: > https://goo.gl/photos/QjeWSHMtphWKpBebA > > Bug: 754186 > Change-Id: I58600912a0c39385a502c7daaaf37cc614f882ab > Reviewed-on: https://chromium-review.googlesource.com/611905 > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#494365} Revert was https://crrev.com/c/615924 Bug: 754186 Change-Id: I9e7652c781708499466126126653cd314c362687 Reviewed-on: https://chromium-review.googlesource.com/616566 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#494770} [modify] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/android/java/res/layout/content_suggestions_card_modern.xml [add] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/android/java/res/layout/content_suggestions_status_card_modern.xml [modify] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java [modify] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java [modify] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/android/java_sources.gni [modify] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NtpUiCaptureTestData.java [modify] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [add] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/HomeSheetEmptyUiCaptureTest.java [modify] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/ContentSuggestionsTestUtils.java [add] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-signin_promo.Nexus_5-19.png [add] https://crrev.com/50141f191674e2e1654259b35eb7070b43b99ee0/chrome/test/data/android/render_tests/ArticleSnippetsTest.signin_promo.Nexus_5-19.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64851d6549e974416f48bf85a95621076393ae16 commit 64851d6549e974416f48bf85a95621076393ae16 Author: Jeremy Roman <jbroman@chromium.org> Date: Wed Aug 16 18:08:04 2017 Revert "Reland "[Suggestions] Add modern styles for sign in promo"" This reverts commit 50141f191674e2e1654259b35eb7070b43b99ee0. Reason for revert: Fails on Android Tests (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44833 Original change's description: > Reland "[Suggestions] Add modern styles for sign in promo" > > This is a reland of 70c937134d62aa896d8b891673d475233d9c122d > Original change's description: > > [Suggestions] Add modern styles for sign in promo > > > > Adds styles to be used for modern cards and uses them in the > > existing one and for the new style of sign in promo. Additionally, > > sign in promos are now at the top in Modern. > > > > Preview: > > https://goo.gl/photos/QjeWSHMtphWKpBebA > > > > Bug: 754186 > > Change-Id: I58600912a0c39385a502c7daaaf37cc614f882ab > > Reviewed-on: https://chromium-review.googlesource.com/611905 > > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#494365} > > Revert was https://crrev.com/c/615924 > > Bug: 754186 > Change-Id: I9e7652c781708499466126126653cd314c362687 > Reviewed-on: https://chromium-review.googlesource.com/616566 > Commit-Queue: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#494770} TBR=bauerb@chromium.org,dgn@chromium.org Change-Id: I2cc9e11c13e1f8a30cbfa8c70ed2392557ef325a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754186 Reviewed-on: https://chromium-review.googlesource.com/617540 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#494860} [modify] https://crrev.com/64851d6549e974416f48bf85a95621076393ae16/chrome/android/java/res/layout/content_suggestions_card_modern.xml [delete] https://crrev.com/e52fea44724e9de0b8b480ddb6ba3ca0737a4966/chrome/android/java/res/layout/content_suggestions_status_card_modern.xml [modify] https://crrev.com/64851d6549e974416f48bf85a95621076393ae16/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/64851d6549e974416f48bf85a95621076393ae16/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/64851d6549e974416f48bf85a95621076393ae16/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java [modify] https://crrev.com/64851d6549e974416f48bf85a95621076393ae16/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java [modify] https://crrev.com/64851d6549e974416f48bf85a95621076393ae16/chrome/android/java_sources.gni [modify] https://crrev.com/64851d6549e974416f48bf85a95621076393ae16/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NtpUiCaptureTestData.java [modify] https://crrev.com/64851d6549e974416f48bf85a95621076393ae16/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [delete] https://crrev.com/e52fea44724e9de0b8b480ddb6ba3ca0737a4966/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/HomeSheetEmptyUiCaptureTest.java [modify] https://crrev.com/64851d6549e974416f48bf85a95621076393ae16/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/64851d6549e974416f48bf85a95621076393ae16/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/ContentSuggestionsTestUtils.java [delete] https://crrev.com/e52fea44724e9de0b8b480ddb6ba3ca0737a4966/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-signin_promo.Nexus_5-19.png [delete] https://crrev.com/e52fea44724e9de0b8b480ddb6ba3ca0737a4966/chrome/test/data/android/render_tests/ArticleSnippetsTest.signin_promo.Nexus_5-19.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02e7221664135cc13502e025b4ab555478c20d5c commit 02e7221664135cc13502e025b4ab555478c20d5c Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Thu Aug 17 01:12:39 2017 Reland "[Suggestions] Add modern styles for sign in promo" This is a reland of 50141f191674e2e1654259b35eb7070b43b99ee0 which it itself a reland of 70c937134d62aa896d8b891673d475233d9c122d Original change's description: > [Suggestions] Add modern styles for sign in promo > > Adds styles to be used for modern cards and uses them in the > existing one and for the new style of sign in promo. Additionally, > sign in promos are now at the top in Modern. > > Preview: > https://goo.gl/photos/QjeWSHMtphWKpBebA > > Bug: 754186 > Change-Id: I58600912a0c39385a502c7daaaf37cc614f882ab > Reviewed-on: https://chromium-review.googlesource.com/611905 > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#494365} Revert was https://crrev.com/c/617540 TBR=bauerb@chromium.org Bug: 754186 Change-Id: I1ddc1a6545e524507168fb3c395b8b268385f399 Reviewed-on: https://chromium-review.googlesource.com/618000 Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#495031} [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/android/java/res/layout/content_suggestions_card_modern.xml [add] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/android/java/res/layout/content_suggestions_status_card_modern.xml [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/android/java_sources.gni [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NtpUiCaptureTestData.java [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [add] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/HomeSheetUiCaptureTest.java [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/ContentSuggestionsTestUtils.java [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-long_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-long_snippet.Nexus_5-19.png [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-long_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-minimal_snippet.Nexus_5-19.png [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-short_minimal_snippet_narrow.Nexus_5-19.png [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-short_snippet.Nexus_5-19.png [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-short_snippet_narrow.Nexus_5-19.png [add] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-signin_promo.Nexus_5-19.png [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-snippets.Nexus_5-19.png [modify] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/test/data/android/render_tests/ArticleSnippetsTest.modern-snippets_narrow.Nexus_5-19.png [add] https://crrev.com/02e7221664135cc13502e025b4ab555478c20d5c/chrome/test/data/android/render_tests/ArticleSnippetsTest.signin_promo.Nexus_5-19.png
Comment 1 by mvanouwe...@chromium.org
, Aug 10 2017Owner: mvanouwe...@chromium.org
Status: Assigned (was: Available)