New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754182 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Clean up around content settings proxies for shared workers and service workers

Project Member Reported by yukiy@google.com, Aug 10 2017

Issue description

This is a follow-up for  https://crbug.com/739092  and  https://crbug.com/734950 

1. Remove origin parameter from mojo args
WorkerContentSettingsProxy passes origin from blink to browser, but browser has this origin, so we can remove this parameter. 

2. Let workers' host have content settings proxy on browser side.
Make workers' host have content settings proxy as member in order to strongly associate the life time of content settings proxies to workers' host.
 

Comment 1 Deleted

Comment 2 Deleted

Comment 3 by yukiy@google.com, Aug 10 2017

Cc: shimazu@google.com
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc1f43afe311480426fe8b98e8534fe79fe3db00

commit bc1f43afe311480426fe8b98e8534fe79fe3db00
Author: Yuki Yamada <yukiy@google.com>
Date: Thu Aug 17 12:18:52 2017

Clean up around content settings proxies for shared workers and service workers.

1. Remove origin parameter from mojo args
Both of SharedWorkerHost and EmbeddedWorkerInstance already have origin,
so WorkerContentSettingsProxy does not have to pass this parametor via mojo.

2. Let workers' host have content settings proxy on browser side
Make worker host have content settings proxy as member in order to
strongly associate the life time of content settings proxies to worker host.

Bug:  754182 
Change-Id: I01c5ce967d5bfffa48f0c8a88fb2f56509f3cbcd
Reviewed-on: https://chromium-review.googlesource.com/615282
Commit-Queue: Yuki Yamada <yukiy@google.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495151}
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/content/browser/service_worker/service_worker_content_settings_proxy_impl.cc
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/content/browser/service_worker/service_worker_content_settings_proxy_impl.h
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/content/browser/shared_worker/shared_worker_content_settings_proxy_impl.cc
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/content/browser/shared_worker/shared_worker_content_settings_proxy_impl.h
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/content/browser/shared_worker/shared_worker_host.h
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/third_party/WebKit/Source/core/workers/SharedWorkerContentSettingsProxy.cpp
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/third_party/WebKit/Source/core/workers/SharedWorkerContentSettingsProxy.h
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContentSettingsProxy.cpp
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContentSettingsProxy.h
[modify] https://crrev.com/bc1f43afe311480426fe8b98e8534fe79fe3db00/third_party/WebKit/public/web/worker_content_settings_proxy.mojom

Comment 5 by yukiy@google.com, Aug 25 2017

Status: Fixed (was: Started)

Sign in to add a comment