Make prebuilt luci-go in Chromium deps'able |
||||
Issue descriptionCurrently luci-go-binary hashes are stored under the tools/luci-go subfolder. Other projects like V8 have their own copy of those files. Currently it is not auto-rolled and can cause breakages when binaries in V8 get too old. Suggestion 1: Make Chromium's tools/luci-go a subtreed repo, so that V8 can directly add it to its DEPS file. Suggestion 2: Move luci-go folder under buildtools. The buildtools folder is already a subtreed repo and deps'ed into V8. Not sure if it's really a meaningful location. E.g. gn binary hashes are there, too, bot those are really needed for building, while luci-go is maybe a different matter.
,
Aug 10 2017
Which of the suggestions is preferable? Is there another alternative?
,
Aug 10 2017
Suggestion 2 isn't quite correct. Buildtools is not a subtreed, it's a separate repo. Like that a drawback of suggestion 2 is that rolling luci-go would require a two stage roll. First a CL inside buildtools, then a separate buildtools roll. This might not be convenient.
,
Oct 4 2017
,
Oct 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d137552822699e748d38d7a86e97ba6e2bce093e commit d137552822699e748d38d7a86e97ba6e2bce093e Author: Michael Achenbach <machenbach@chromium.org> Date: Mon Oct 09 18:52:13 2017 Build: Properly nest gitignore for luci-go The directory tools/luci-go is now under a subtreed repo mirror and should have its own gitignore file. Bug: chromium:754168 Change-Id: I716b6c853f04c9284287e417500a821c01dab8c4 Reviewed-on: https://chromium-review.googlesource.com/707146 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#507430} [modify] https://crrev.com/d137552822699e748d38d7a86e97ba6e2bce093e/.gitignore [add] https://crrev.com/d137552822699e748d38d7a86e97ba6e2bce093e/tools/luci-go/.gitignore
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/17fbcbe184bfa6ad93a15b9560a84344d8512042 commit 17fbcbe184bfa6ad93a15b9560a84344d8512042 Author: Michael Achenbach <machenbach@chromium.org> Date: Tue Oct 10 07:04:59 2017 [build] Depend on luci-go via subtree repo Bug: chromium:754168 Change-Id: Ie3c80b7f566f6738893cc30f26b35b7862eccc6c Reviewed-on: https://chromium-review.googlesource.com/706996 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#48413} [modify] https://crrev.com/17fbcbe184bfa6ad93a15b9560a84344d8512042/.gitignore [modify] https://crrev.com/17fbcbe184bfa6ad93a15b9560a84344d8512042/DEPS [delete] https://crrev.com/6102609b3bc3812ab52cdeb0b8612d63789d0f4a/tools/luci-go/linux64/isolate.sha1 [delete] https://crrev.com/6102609b3bc3812ab52cdeb0b8612d63789d0f4a/tools/luci-go/mac64/isolate.sha1 [delete] https://crrev.com/6102609b3bc3812ab52cdeb0b8612d63789d0f4a/tools/luci-go/win64/isolate.exe.sha1
,
Oct 10 2017
This is a subtree repo now and subprojects can deps into it. @webrtc, fyi
,
Oct 10 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mar...@chromium.org
, Aug 10 2017Components: Infra>Platform>Swarming