New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754167 link

Starred by 1 user
Status: Fixed
Owner:
█ emim@google.com
Last visit > 30 days ago
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove obsolete ServiceWorkerDispatcherHost crash keys

Project Member Reported by falken@chromium.org, Aug 10 2017 
We can remove all the code with comment "// Temporary for https://crbug.com/668633"

E.g.,
      // Temporary for https://crbug.com/668633.
      {"swdh_set_hosted_version_worker_pid", kSmallSize},
      {"swdh_set_hosted_version_host_pid", kSmallSize},
      {"swdh_set_hosted_version_is_new_process", kSmallSize},
      {"swdh_set_hosted_version_restart_count", kSmallSize},

It's in a few files.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cc0c47e319ea007c3ca258f6be2a4275cd629cd

commit 2cc0c47e319ea007c3ca258f6be2a4275cd629cd
Author: Emi Morikawa <emim@google.com>
Date: Tue Aug 15 08:32:04 2017

Remove obsolete crash keys for swdh_set_hosted_version_*.

bug 668633 has been fixed and these crash keys are no longer used.

Bug:  754167 , 668633
Change-Id: Ia2b31a1ace3e471513664ed49f3ccc9f91610885
TBR: jam
Reviewed-on: https://chromium-review.googlesource.com/611694
Commit-Queue: Emi Morikawa <emim@google.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494344}
[modify] https://crrev.com/2cc0c47e319ea007c3ca258f6be2a4275cd629cd/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/2cc0c47e319ea007c3ca258f6be2a4275cd629cd/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/2cc0c47e319ea007c3ca258f6be2a4275cd629cd/chrome/common/crash_keys.cc
[modify] https://crrev.com/2cc0c47e319ea007c3ca258f6be2a4275cd629cd/chromecast/crash/cast_crash_keys.cc

Comment 2 by emim@google.com, Aug 16 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment