New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754165 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Aug 2017
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ContentSuggestions Open in New Tab should open in background

Project Member Reported by gambard@chromium.org, Aug 10 2017 
What steps will reproduce the problem?
(1) Open ContentSuggestions
(2) Long press any item
(3) Tap Open in New Tab

What is the expected result?
The article should be opened in background

What happens instead?
The new tab is opened in foreground.

Note that the Open in New Incognito Tab should still be opened in foreground.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46736273cdeff7cf5c10bfb1d7872a3831687a4d

commit 46736273cdeff7cf5c10bfb1d7872a3831687a4d
Author: gambard <gambard@chromium.org>
Date: Fri Aug 11 09:04:00 2017

Open new tab in foreground only for incognito

The NTP is displayed on non-incognito. The correct behavior for opening
a new tab is to open it in foreground only if it is from non-incognito
to incognito.

Bug:  754165 
Change-Id: I562948064d7ddf0bf217e2ed76c3feddbf3ba34e
Reviewed-on: https://chromium-review.googlesource.com/610224
Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493690}
[modify] https://crrev.com/46736273cdeff7cf5c10bfb1d7872a3831687a4d/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

Comment 2 by gambard@chromium.org, Aug 11 2017

Status: Fixed (was: Assigned)

Comment 3 by vbhatso...@chromium.org, Aug 15 2017

Status: Verified (was: Fixed)
Verified on build 62.0.31860 Canary in iPhone 7+ iOS 10.3.3, iPhone 6+ iOS 11.0 Beta 5, iPad Pro 12.5' iOS 10.3.3
Long press on any item , opens in a new tab in the background.
Long press on any item , opens in a new incognito tab in the foreground.
►

Sign in to add a comment