browser_tests: PageLoadMetricsBrowserTest.CSSTiming flaky on chromium.linux/Linux Tests and Win7/dbg |
|||||||||||||||
Issue descriptionbrowser_tests failing on chromium.linux/Linux Tests Builders failed on: - Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests failed builds: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/60597 https://uberchromegw.corp.google.com/p/chromium.linux/builders/Linux%20Tests/builds/60606 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/60607 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/60608 [ RUN ] PageLoadMetricsBrowserTest.CSSTiming Xlib: extension "RANDR" missing on display ":99". [17876:17876:0809/235912.357240:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.PaintTiming.NavigationToFirstContentfulPaint" does not exist. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.CSSTiming.Parse.BeforeFirstContentfulPaint" does not exist. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.CSSTiming.Update.BeforeFirstContentfulPaint" does not exist. [17876:18083:0809/235912.592502:WARNING:embedded_test_server.cc(225)] Request not handled. Returning 404: /favicon.ico ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.CSSTiming.ParseAndUpdate.BeforeFirstContentfulPaint" does not exist. [18063:18063:0809/235912.607928:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1 [18063:18063:0809/235912.607975:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1 [ FAILED ] PageLoadMetricsBrowserTest.CSSTiming, where TypeParam = and GetParam() = (617 ms) [ RUN ] PageLoadMetricsBrowserTest.CSSTiming Xlib: extension "RANDR" missing on display ":99". [25447:25447:0810/000447.923658:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.PaintTiming.NavigationToFirstContentfulPaint" does not exist. [25447:25522:0810/000448.111580:WARNING:embedded_test_server.cc(225)] Request not handled. Returning 404: /favicon.ico ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.CSSTiming.Parse.BeforeFirstContentfulPaint" does not exist. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.CSSTiming.Update.BeforeFirstContentfulPaint" does not exist. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.CSSTiming.ParseAndUpdate.BeforeFirstContentfulPaint" does not exist. [ FAILED ] PageLoadMetricsBrowserTest.CSSTiming, where TypeParam = and GetParam() = (509 ms) [ RUN ] PageLoadMetricsBrowserTest.CSSTiming Xlib: extension "RANDR" missing on display ":99". [25700:25700:0810/000449.758726:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.PaintTiming.NavigationToFirstContentfulPaint" does not exist. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.CSSTiming.Parse.BeforeFirstContentfulPaint" does not exist. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.CSSTiming.Update.BeforeFirstContentfulPaint" does not exist. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.CSSTiming.ParseAndUpdate.BeforeFirstContentfulPaint" does not exist. [25700:25771:0810/000449.946701:WARNING:embedded_test_server.cc(225)] Request not handled. Returning 404: /favicon.ico [ FAILED ] PageLoadMetricsBrowserTest.CSSTiming, where TypeParam = and GetParam() = (505 ms) [ RUN ] PageLoadMetricsBrowserTest.CSSTiming Xlib: extension "RANDR" missing on display ":99". [25784:25784:0810/000450.410373:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.PaintTiming.NavigationToFirstContentfulPaint" does not exist. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.CSSTiming.Parse.BeforeFirstContentfulPaint" does not exist. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.CSSTiming.Update.BeforeFirstContentfulPaint" does not exist. ../../base/test/histogram_tester.cc:72: Failure Expected: count Which is: 1 To be equal to: 0 Histogram "PageLoad.CSSTiming.ParseAndUpdate.BeforeFirstContentfulPaint" does not exist. [ FAILED ] PageLoadMetricsBrowserTest.CSSTiming, where TypeParam = and GetParam() = (492 ms)
,
Aug 10 2017
,
Aug 10 2017
,
Aug 10 2017
,
Aug 10 2017
Disabling it: https://chromium-review.googlesource.com/c/609064
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cad3029f0617502594e3d96328387d7d79fb156f commit cad3029f0617502594e3d96328387d7d79fb156f Author: Olga Sharonova <olka@chromium.org> Date: Thu Aug 10 11:19:39 2017 Disabling PageLoadMetricsBrowserTest.CSSTiming on Linux: flaky TBR=bmcquade@chromium.org Bug: 754158 Change-Id: Iaf94b7a4c3c2d0413b3aa838f7ef3f78c98a82c5 Reviewed-on: https://chromium-review.googlesource.com/609064 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#493356} [modify] https://crrev.com/cad3029f0617502594e3d96328387d7d79fb156f/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
,
Aug 10 2017
,
Aug 10 2017
suspect https://chromium-review.googlesource.com/c/596347
,
Aug 10 2017
,
Aug 10 2017
Chris, do you know who owns the page metrics browser tests? Disabling this test for everyone for now. It's flaky on multiple platforms.
,
Aug 10 2017
csharrison owns this particular test, so this is correctly assigned. Charles, this looks like it may be due to a regression. Perhaps someone landed a change that made your test flaky? If so, we may want to see if that change should be reverted.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae7c11d25bf23357767bd0b6e1ae10d28381eb8f commit ae7c11d25bf23357767bd0b6e1ae10d28381eb8f Author: Fernando Serboncini <fserb@google.com> Date: Thu Aug 10 15:22:49 2017 Disable flaky CSSTiming test TBR=csharrison Bug: 754158 Change-Id: Iebd4c531d7479b304585aeefb3ea772421716062 Reviewed-on: https://chromium-review.googlesource.com/610440 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#493397} [modify] https://crrev.com/ae7c11d25bf23357767bd0b6e1ae10d28381eb8f/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
,
Aug 10 2017
,
Aug 10 2017
Thanks, I don't see anything very suspicious in the flakiness range, but I can look further into it.
,
Aug 10 2017
,
Aug 10 2017
This may be flaking due to the recently landed change to use swap times for FP/FCP/etc: https://chromium-review.googlesource.com/c/576371 That change can cause some extra delay in dispatching the paint timings. Since the histograms in the test are logged in an FCP callback, it looks like the PageLoadMetricsWaiter needs to wait on FIRST_CONTENTFUL_PAINT. Since these histograms are only logged in the FCP callback, we can probably remove waiting on STYLE_UPDATE_BEFORE_FCP, and since this is the only test that uses STYLE_UPDATE_BEFORE_FCP, we can remove support for that wait condition altogether as well. So this seems like a bug in the test that was exposed by the recent swap times change - we should just update and re-enable the test. csharrison, WDYT?
,
Aug 11 2017
I coded up the proposed fix & it appears to work, so will send out for review shortly.
,
Aug 11 2017
Thanks Bryan, I appreciate it. Was hoping to get to it today but I haven't yet.
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ca9865e6a7a4020c2d29e7c86da1b977866043e commit 9ca9865e6a7a4020c2d29e7c86da1b977866043e Author: Bryan McQuade <bmcquade@chromium.org> Date: Mon Aug 14 22:11:07 2017 Fix and re-enable CSSTiming PLMBrowserTest. Bug: 754158 Change-Id: I418086b2efd9052b615f280fd6fa7b29243230aa Reviewed-on: https://chromium-review.googlesource.com/612424 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#494203} [modify] https://crrev.com/9ca9865e6a7a4020c2d29e7c86da1b977866043e/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
,
Aug 14 2017
There is also a flaky failure in SessionRestorePageLoadMetricsBrowserTest.MultipleTabsSessionRestore and some other tests from this file. Do you think this change will resolve them all?
,
Aug 14 2017
No, that must be a separate issue. Can you file another bug and assign ducbui@google.com (author of the test)
,
Nov 24 2017
,
Jan 24 2018
,
Jan 24 2018
,
Mar 20 2018
Closing this given comment 21. |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by olka@chromium.org
, Aug 10 2017