WprGo: convert_legacy_wpr_archive fails to convert loading_desktop |
|||||
Issue description$ tools/perf/convert_legacy_wpr_archive tools/perf/page_sets/data/loading_desktop.json (snip) https://www.mlbstatic.com/mlb.com/builds/site-core/e16a01fee8bfb6e74167bf380250f08039668488_1493138358/patterns/mlbtvad/mlbtvad.js accept-language: en-US,en;q=0.8 accept-encoding: gzip,deflate,br connection: keep-alive accept: */* user-agent: Mozilla/5.0 (Linux; Android 4.0.4; Galaxy Nexus Build/IMM76B) AppleWebKit/535.36 (KHTML, like Gecko) Chrome/40.0.2194.2 Mobile Safari/535.36 host: www.mlbstatic.com referer: https://www.mlb.com/ reqHeader map[Accept:[*/*] User-Agent:[Mozilla/5.0 (Linux; Android 4.0.4; Galaxy Nexus Build/IMM76B) AppleWebKit/535.36 (KHTML, like Gecko) Chrome/40.0.2194.2 Mobile Safari/535.36] Host:[www.mlbstatic.com] Referer:[https://www.mlb.com/] Accept-Language:[en-US,en;q=0.8] Accept-Encoding:[gzip,deflate,br] Connection:[keep-alive]] (DEBUG) 2017-08-10 13:38:55,074 httpproxy.do_parse_and_handle_one_request:263 Served: GET https://www.mlbstatic.com/mlb.com/builds/site-core/e16a01fee8bfb6e74167bf380250f08039668488_1493138358/patterns/mlbtvad/mlbtvad.js [('accept-encoding', 'gzip,deflate,br'), ('host', 'www.mlbstatic.com')] (2ms) status: 200 panic: failed: parse https://tpc.googlesyndication.com/safeframe/1-0-8/html/[%Thirdpartyimpressiontracker%]: invalid URL escape "%Th" goroutine 1 [running]: webpagereplay.(*ConvertorConfig).Convert(0xc42015a000, 0xc4200d6c80) /usr/local/google/home/xunjieli/catapult/web_page_replay_go/src/webpagereplay/legacyformatconvertor.go:145 +0x1701 webpagereplay.(*ConvertorConfig).Convert-fm(0xc4200d6c80) /usr/local/google/home/xunjieli/catapult/web_page_replay_go/src/wpr.go:436 +0x34 github.com/codegangsta/cli.HandleAction(0x78cca0, 0xc420072f30, 0xc4200d6c80, 0xc42007e400, 0x0) /usr/local/google/home/xunjieli/go/src/github.com/codegangsta/cli/app.go:487 +0x7c github.com/codegangsta/cli.Command.Run(0x81f734, 0x7, 0x0, 0x0, 0x0, 0x0, 0x0, 0x82c0b7, 0x29, 0x0, ...) /usr/local/google/home/xunjieli/go/src/github.com/codegangsta/cli/command.go:207 +0xa95 github.com/codegangsta/cli.(*App).Run(0xc4200acd00, 0xc42000e080, 0x8, 0x8, 0x0, 0x0) /usr/local/google/home/xunjieli/go/src/github.com/codegangsta/cli/app.go:250 +0x758 github.com/codegangsta/cli.(*App).RunAndExitOnError(0xc4200acd00) /usr/local/google/home/xunjieli/go/src/github.com/codegangsta/cli/app.go:271 +0x53 main.main() /usr/local/google/home/xunjieli/catapult/web_page_replay_go/src/wpr.go:446 +0x1291 fail to start wpr go
,
Aug 10 2017
I am not sure why the legacy wpr has an unescaped string like [%Thirdpartyimpressiontracker%] in the url. Can you patch this temporary workaround CL (https://chromium-review.googlesource.com/c/610360) and try again?
,
Aug 11 2017
ksakamoto@: please assign back if that doesn't solve the issue. Thanks.
,
Aug 14 2017
Thanks! It worked.
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca2e6be7bac44462efdd864ef346311b9a6033de commit ca2e6be7bac44462efdd864ef346311b9a6033de Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Tue Aug 15 04:08:53 2017 Convert loading.desktop page set to WprGo Converted using patched convert_legacy_wpr_archive (https://chromium-review.googlesource.com/c/610360), to workaround a panic due to a malformed URL in www.mlb.com WPR. Bug: 730036 , 754130 Change-Id: I070267a9cfa0ef9df3f9c0504bcdd9f4f8c283cd Reviewed-on: https://chromium-review.googlesource.com/612935 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#494323} [modify] https://crrev.com/ca2e6be7bac44462efdd864ef346311b9a6033de/tools/perf/page_sets/data/loading_desktop.json [delete] https://crrev.com/ec9b11655f9b69decac3aba65c23627cab7c040c/tools/perf/page_sets/data/loading_desktop_000.wpr.sha1 [add] https://crrev.com/ca2e6be7bac44462efdd864ef346311b9a6033de/tools/perf/page_sets/data/loading_desktop_000.wprgo.sha1 [delete] https://crrev.com/ec9b11655f9b69decac3aba65c23627cab7c040c/tools/perf/page_sets/data/loading_desktop_001.wpr.sha1 [add] https://crrev.com/ca2e6be7bac44462efdd864ef346311b9a6033de/tools/perf/page_sets/data/loading_desktop_001.wprgo.sha1 [delete] https://crrev.com/ec9b11655f9b69decac3aba65c23627cab7c040c/tools/perf/page_sets/data/loading_desktop_002.wpr.sha1 [add] https://crrev.com/ca2e6be7bac44462efdd864ef346311b9a6033de/tools/perf/page_sets/data/loading_desktop_002.wprgo.sha1 [delete] https://crrev.com/ec9b11655f9b69decac3aba65c23627cab7c040c/tools/perf/page_sets/data/loading_desktop_003.wpr.sha1 [add] https://crrev.com/ca2e6be7bac44462efdd864ef346311b9a6033de/tools/perf/page_sets/data/loading_desktop_003.wprgo.sha1 [delete] https://crrev.com/ec9b11655f9b69decac3aba65c23627cab7c040c/tools/perf/page_sets/data/loading_desktop_005.wpr.sha1 [add] https://crrev.com/ca2e6be7bac44462efdd864ef346311b9a6033de/tools/perf/page_sets/data/loading_desktop_005.wprgo.sha1
,
Aug 15 2017
Closing. Thanks for your help xunjieli!
,
Jan 16
,
Jan 16
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xunji...@chromium.org
, Aug 10 2017