[Media Router WebUI] Improve the accessibility of the Cast dialog |
|||
Issue descriptionSome of the issues pointed out during accessibility review: Screen readers: - The volume slider reads out a very long float number; should be truncated - The time slider does not read out the current position properly - The current position and duration labels don't say what those numbers are - Cannot use the sliders while using VoiceOver - VoiceOver gives instructions (e.g. use ctrl-option-right on the sink list) which don't do anything Color: - The focus indicator on the blue header isn't dark enough to see Accessibility review at crbug.com/753129
,
Aug 17 2017
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8555d3cafae3cd571d83d9a6d6900845c48aa089 commit 8555d3cafae3cd571d83d9a6d6900845c48aa089 Author: Takumi Fujimoto <takumif@chromium.org> Date: Fri Aug 18 22:16:44 2017 [Media Router WebUI] Round the value on the volume slider Round the value that we set on the volume slider whenever there is a MediaStatus update, so that the value is screen-reader friendly (e.g. zero-point-seven-two instead of zero-point-seven-one-nine-nine-nine...) The values set by manipulating the slider is already screen-reader friendly. Bug: 754105 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9d591d3bf17bb71204110ad0638146acf6333449 Reviewed-on: https://chromium-review.googlesource.com/621829 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#495714} [modify] https://crrev.com/8555d3cafae3cd571d83d9a6d6900845c48aa089/chrome/browser/resources/media_router/elements/route_controls/route_controls.js
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d63505bf3303a0420ea3b438c728394841556dd commit 3d63505bf3303a0420ea3b438c728394841556dd Author: Takumi Fujimoto <takumif@chromium.org> Date: Mon Aug 21 20:56:03 2017 [Media Router WebUI] Prevent slider knobs from jumping when using keyboard When the user is moving the seek or volume slider knob with arrow keys, the knob can jump around due to the controller receiving delayed time/volume updates originating from itself. So we'll ignore updates for 1 second after the user stops interacting. This will mean that if another user changes time/volume for the same route within 1 second that change won't get applied to the controller (until next status update is received), but that situation seems fairly unlikely. Bug: 754105 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8d200b68783bf774499172410fcba0cdb3500e02 Reviewed-on: https://chromium-review.googlesource.com/622008 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#496057} [modify] https://crrev.com/3d63505bf3303a0420ea3b438c728394841556dd/chrome/browser/resources/media_router/elements/route_controls/route_controls.js [modify] https://crrev.com/3d63505bf3303a0420ea3b438c728394841556dd/chrome/test/data/webui/media_router/route_controls_tests.js
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c506c8fc99469c47c645ae9f44e434f21d0b7aa2 commit c506c8fc99469c47c645ae9f44e434f21d0b7aa2 Author: Takumi Fujimoto <takumif@chromium.org> Date: Thu Aug 24 20:57:25 2017 [Media Router WebUI] Give aria-valuetext to volume slider Some screen readers (NVDA, ChromeVox) read out long decimals for slider values even if the value set is a shorter decimal (e.g. 0.35 vs 0.34999...). This seems to be an issue with the Polymer paper-slider. This CL works around the issue by adding aria-valuetext attribute (e.g. "35%") to the volume slider to be read by screen readers. This CL also replaces |volumeSliderValue_| with |displayedVolume_|, since the former is set but never used, which seems like a bug. Bug: 754105 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ice981ed294e14e32b39e30a604ebd76c4b02e676 Reviewed-on: https://chromium-review.googlesource.com/629556 Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#497186} [modify] https://crrev.com/c506c8fc99469c47c645ae9f44e434f21d0b7aa2/chrome/browser/resources/media_router/elements/route_controls/route_controls.html [modify] https://crrev.com/c506c8fc99469c47c645ae9f44e434f21d0b7aa2/chrome/browser/resources/media_router/elements/route_controls/route_controls.js
,
Dec 7 2017
I believe we've addressed all the outstanding issues with the dialog. Closing. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Aug 11 2017