New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754104 link

Starred by 11 users
Status: Started
Owner:
jbudorick@chromium.org
Cc:
jam@chromium.org
█ phajdan.jr@chromium.org
tandrii@chromium.org
bpastene@chromium.org
no...@chromium.org
vadimsh@chromium.org
martiniss@chromium.org
estaab@chromium.org
jbudorick@chromium.org
█ smut@chromium.org
scottmg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 838767
issue 893686
Blocking:
issue 753184
issue 878321
issue 922636



Sign in to add a comment

replace package_build / extract_build with upload/download of lists of isolate tasks

Project Member Reported by dpranke@chromium.org, Aug 10 2017 
Now that almost everything is being run under swarming, we should get rid of the (mostly) redundant package_build / extract_build steps on the waterfall builders that have builder/tester splits, and instead just upload a list of swarming tasks to run (isolate hashes + command lines + metadata for steps) and download them on the testers.

This is currently done and working on the internal ios bots, so porting this over should be conceptually straightforward.

In order for that to be possible, we need to make sure that in fact *all* of the desired tests are swarmed. Most notable, we can't do this on bots that run layout tests until they are swarmed :(.

Any volunteers to work on this?

Comment 1 by dpranke@chromium.org, Aug 10 2017

Blocking: 753184

Comment 2 by jbudorick@chromium.org, Aug 10 2017

Owner: jbudorick@chromium.org
Status: Assigned (was: Untriaged)
I'll take this.

Comment 3 by dpranke@chromium.org, Aug 10 2017 

I talked to phajdan.jr@ about this as well, it might be a better use of time for him to work on this and you can help bpastene w/ the single-device-swarming-related work.

Comment 4 by jbudorick@chromium.org, Aug 10 2017

Owner: ----
Status: Available (was: Assigned)
alright, releasing this.

Comment 5 by bpastene@chromium.org, Aug 24 2017 

Issue 657315 has been merged into this issue.

Comment 6 by jbudorick@chromium.org, Oct 31 2017

Owner: jbudorick@chromium.org
Status: Assigned (was: Available)

Comment 7 by mar...@chromium.org, Nov 1 2017

Cc: vadimsh@chromium.org no...@chromium.org scottmg@chromium.org jam@chromium.org tandrii@chromium.org
 Issue 496321  has been merged into this issue.

Comment 8 by dpranke@chromium.org, Nov 2 2017

Cc: martiniss@chromium.org nednguyen@chromium.org
implementation note / thought: I think we could ideally implement this by something that uploaded a data file consisting solely of the tasks to wait on, and an auxiliary script (or scripts) that could merge the output from multiple shards and then upload them somewhere, assuming we properly standardized the merging logic (which we're working on in http://bit.ly/chromium-test-artifacts . 

If we do that right, then the "tester" config could be a totally separate recipe that didn't require a chromium checkout at all, which could significantly improve the cycle time on those bots *and* improve our overall fleet efficiency, particularly if we switch the trybots to doing a triggered builder/tester split as well (i.e., big builder, small waiter).

Comment 9 by ynovikov@chromium.org, Dec 21 2017

Blocking: 793971

Comment 10 by jbudorick@chromium.org, Jan 19 2018

Status: Started (was: Assigned)
Taking a slightly different (and more limited) tack on this w/ the initial CL than suggested in #8. I'm only planning to eliminate package_build/extract_build for now. I do think moving to the thin test waiter model is a worthwhile goal, though.

Comment 11 by serg...@chromium.org, Jan 19 2018 

FYI: This looks similar to what V8 does. We also just grab isolates from builders and trigger jobs on swarming. This allows us to run 30 testers per machine (multibots) since they mostly just wait for swarming jobs to complete and summarize the results. I've also recently added support for multibots on swarming [1].

[1]: https://chromium.googlesource.com/infra/infra/+/master/infra/services/swarm_docker/

Comment 12 by dpranke@chromium.org, Jan 19 2018 

@sergiyb - yup, v8's model was a big inspiration.
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d93c3f10c320ba73d7e073db69a576fa328e0a0d

commit d93c3f10c320ba73d7e073db69a576fa328e0a0d
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Apr 27 01:17:00 2018

[chromium_tests] Split packaging, isolation, archival, and triggering.

Additionally, attempt to skip packaging altogether on bots using the
staging version chromium_tests that only run swarmed tests.

Bug: 754104
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Change-Id: Ib0b0f0fdce96cd66c1ef16320919dcda818e5c87
Reviewed-on: https://chromium-review.googlesource.com/875166
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/d93c3f10c320ba73d7e073db69a576fa328e0a0d/scripts/slave/recipe_modules/chromium_tests/tests/api/archive_build.py
[add] https://crrev.com/d93c3f10c320ba73d7e073db69a576fa328e0a0d/scripts/slave/recipe_modules/chromium_tests/tests/api/package_build.py
[copy] https://crrev.com/d93c3f10c320ba73d7e073db69a576fa328e0a0d/scripts/slave/recipe_modules/chromium_tests/tests/api/package_build.expected/linux_builder.json
[rename] https://crrev.com/d93c3f10c320ba73d7e073db69a576fa328e0a0d/scripts/slave/recipe_modules/chromium_tests/tests/api/package_build.expected/linux_perf_bisect_builder.json
[add] https://crrev.com/d93c3f10c320ba73d7e073db69a576fa328e0a0d/scripts/slave/recipe_modules/chromium_tests/tests/api/trigger_child_builds.py
[modify] https://crrev.com/d93c3f10c320ba73d7e073db69a576fa328e0a0d/scripts/slave/README.recipes.md
[rename] https://crrev.com/d93c3f10c320ba73d7e073db69a576fa328e0a0d/scripts/slave/recipe_modules/chromium_tests/tests/api/package_build.expected/linux_perf_builder.json
[modify] https://crrev.com/d93c3f10c320ba73d7e073db69a576fa328e0a0d/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/d93c3f10c320ba73d7e073db69a576fa328e0a0d/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.py
[delete] https://crrev.com/c39d39e01eb6ed16da7ca89821aaca395d935bc1/scripts/slave/recipe_modules/chromium_tests/tests/api/archive_build.expected/cross_master_trigger.json
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/6c77ee6e31155ffae5a035348eaff3899d04d394

commit 6c77ee6e31155ffae5a035348eaff3899d04d394
Author: John Budorick <jbudorick@google.com>
Date: Fri Apr 27 01:35:58 2018

Comment 15 by jbudorick@chromium.org, May 2 2018

Blockedon: 838767
Project Member

Comment 16 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/cf7221561593d7fea13396e2da3e757d82eba559

commit cf7221561593d7fea13396e2da3e757d82eba559
Author: John Budorick <jbudorick@chromium.org>
Date: Thu May 03 22:57:43 2018

chromium_tests: use isolate transfer if all tester tests are isolated.

i.e., even if the *builder* is running non-isolated tests.

Bug: 754104
Change-Id: Ibd4430a16f55e9543a1c5a6b68619e45419d42cd
Reviewed-on: https://chromium-review.googlesource.com/1042788
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/cf7221561593d7fea13396e2da3e757d82eba559/scripts/slave/README.recipes.md
[modify] https://crrev.com/cf7221561593d7fea13396e2da3e757d82eba559/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/cf7221561593d7fea13396e2da3e757d82eba559/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.py

Comment 17 by ynovikov@chromium.org, May 17 2018

Blocking: -793971
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5672ffd53baa445021c6ef6a732fcc4aa7773d5b

commit 5672ffd53baa445021c6ef6a732fcc4aa7773d5b
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Sep 07 18:25:58 2018

Add telemetry_perf_unittests arguments to chromium_tests staging builder.

Bug: 754104
Change-Id: I8f2f41bcc2c41310dbdd5f88083f5818373f2613
Reviewed-on: https://chromium-review.googlesource.com/1213473
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589590}
[modify] https://crrev.com/5672ffd53baa445021c6ef6a732fcc4aa7773d5b/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/5672ffd53baa445021c6ef6a732fcc4aa7773d5b/testing/buildbot/test_suite_exceptions.pyl

Comment 21 by bpastene@chromium.org, Sep 11

Cc: bpastene@chromium.org
 Issue 880932  has been merged into this issue.
Project Member

Comment 23 by bugdroid1@chromium.org, Sep 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3f5335bc4e51feb8e251f0c53f994e9495efe492

commit 3f5335bc4e51feb8e251f0c53f994e9495efe492
Author: John Budorick <jbudorick@chromium.org>
Date: Wed Sep 12 21:13:18 2018

chromium_tests: promote isolate transfer & test rewrite to prod.

Recipe-Manual-Change: build_limited_scripts_slave
Recipe-Manual-Change: release_scripts
Bug: 754104
Change-Id: Ib3f686bda765c00d5b31b0d57cc5d6fea8f5a7d0
Reviewed-on: https://chromium-review.googlesource.com/1208531
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>

[modify] https://crrev.com/3f5335bc4e51feb8e251f0c53f994e9495efe492/scripts/slave/recipe_modules/findit/api.py
[modify] https://crrev.com/3f5335bc4e51feb8e251f0c53f994e9495efe492/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.py
[modify] https://crrev.com/3f5335bc4e51feb8e251f0c53f994e9495efe492/scripts/slave/recipes/swarming/staging.py
[modify] https://crrev.com/3f5335bc4e51feb8e251f0c53f994e9495efe492/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py
[modify] https://crrev.com/3f5335bc4e51feb8e251f0c53f994e9495efe492/scripts/slave/README.recipes.md
[modify] https://crrev.com/3f5335bc4e51feb8e251f0c53f994e9495efe492/scripts/slave/recipes/findit/chromium/compile.py
[modify] https://crrev.com/3f5335bc4e51feb8e251f0c53f994e9495efe492/scripts/slave/recipes/android/builder.py
[modify] https://crrev.com/3f5335bc4e51feb8e251f0c53f994e9495efe492/scripts/slave/recipes/pinpoint/builder.py
[modify] https://crrev.com/3f5335bc4e51feb8e251f0c53f994e9495efe492/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/3f5335bc4e51feb8e251f0c53f994e9495efe492/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder.json
Project Member

Comment 24 by bugdroid1@chromium.org, Sep 12 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/33816e2bc5c1b78cd0d49b7fce9fa1367ce71944

commit 33816e2bc5c1b78cd0d49b7fce9fa1367ce71944
Author: John Budorick <jbudorick@google.com>
Date: Wed Sep 12 21:18:59 2018
Project Member

Comment 25 by bugdroid1@chromium.org, Sep 12 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/6edc884496ad1d3d79d04d625ec3ce925c007164

commit 6edc884496ad1d3d79d04d625ec3ce925c007164
Author: John Budorick <jbudorick@google.com>
Date: Wed Sep 12 21:31:31 2018

Comment 26 by jbudorick@chromium.org, Sep 12 

#23 caused a bunch of transient failures on landing, w/ builders that didn't have the recipe change triggering testers that did: https://bugs.chromium.org/p/chromium/issues/detail?id=883495

Comment 27 by jbudorick@chromium.org, Sep 12

Blocking: 878321
Project Member

Comment 29 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d31d6bee383a13155c0323b4866e6feddb89e23b

commit d31d6bee383a13155c0323b4866e6feddb89e23b
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Sep 21 17:00:44 2018

chromium_tests: merge create_{,generalized_}bot_config_object.

Bug: 754104
Recipe-Manual-Change: release_scripts
Recipe-Manual-Change: build_limited_scripts_slave
Change-Id: I60b6fee45ad5e7879fc8ec648f6ea2f8071f7679
Reviewed-on: https://chromium-review.googlesource.com/1208532
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>

[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipes/findit/chromium/update_components.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/findit/api.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipes/findit/chromium/compile_isolate.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/api/archive_build.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/api/package_build.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipes/bisection/android_bisect.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipes/bisection/desktop_bisect.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/api/wrap_chromium_tests.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/auto_bisect/examples/full.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipes/findit/chromium/preemptive_bot_update.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/api/prepare_checkout.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/api/trigger_child_builds.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_checkout/tests/full.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipes/bisection/desktop_bisect_staging.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium/examples/full.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipes/bisection/android_bisect_staging.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/api/runhooks.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/builders.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/api/deapply_patch.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipes/pinpoint/builder.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipes/swarming/staging.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/api/get_common_args_for_scripts.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/README.recipes.md
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipes/findit/chromium/compile.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/api/configure_build.py
[modify] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipes/android/builder.py
[rename] https://crrev.com/d31d6bee383a13155c0323b4866e6feddb89e23b/scripts/slave/recipe_modules/chromium_tests/tests/api/create_bot_config_object.py
Project Member

Comment 30 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/135029e088037acf2d767537465f4ed6be27607a

commit 135029e088037acf2d767537465f4ed6be27607a
Author: John Budorick <jbudorick@google.com>
Date: Fri Sep 21 17:49:27 2018
Project Member

Comment 31 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/b45793eec876044ffbabea1e973a14adc53eda4e

commit b45793eec876044ffbabea1e973a14adc53eda4e
Author: John Budorick <jbudorick@google.com>
Date: Fri Sep 21 18:24:13 2018

Comment 32 by jbudorick@chromium.org, Sep 21 

This has been live for the last week (since c#28).

Status:
 - LUCI builders that only trigger fully isolated testers will not package their builds. LUCI builders that trigger a tester that includes any isolated test will use isolate transfer. The combination means that some builders can do both isolate transfer *and* package transfer.
 - LUCI testers that are fully isolated will not download + extract their builds.
 - buildbot builders always rely on package transfer b/c buildbot's trigger mechanism is liable to be overloaded by the addition of swarm_hashes

At this point, builders that are still doing package transfer either:
 - need to be converted to LUCI
 - need to ensure all tests are isolated

... neither of which is in scope of this bug. However, before closing this out, I'm going to add a step to explain why a builder is still doing package transfer to facilitate folks trying to get rid of package transfer.
Project Member

Comment 33 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8b142919694b144bb2e98648b202edaaa4e11438

commit 8b142919694b144bb2e98648b202edaaa4e11438
Author: John Budorick <jbudorick@chromium.org>
Date: Thu Oct 04 22:39:16 2018

chromium_tests: log why a builder is still using package transfer.

Bug: 754104
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Change-Id: Idb58fcab8a3670bb38ce3c6eaa0dd0a0f512ab5b
Reviewed-on: https://chromium-review.googlesource.com/c/1262715
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder_on_buildbot.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_gtest_android.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_script_test_with_args.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipe_modules/archive/api.py
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/msan.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_custom_name.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/one_failure_keeps_going_dynamic_tests.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_passed_json_results.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/buildnumber_zero.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_gtest_fuchsia.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_gtest_win.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_gtest.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_junit_test.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/tester.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_unknown_json_results.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_asan_no_lsan.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_serialized_gtests.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_custom_results_handler.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_no_json.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_json_isolated_script_test.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_script_test_failure.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_corrupt_json_results.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/kitchen_path_config.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/generic_path_config.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_failed_json_results.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/tsan.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/README.recipes.md
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_gtest_on_builder.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json
[modify] https://crrev.com/8b142919694b144bb2e98648b202edaaa4e11438/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json
Project Member

Comment 34 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3a28e547034fe8859fa18560beb67a5ea0bb70a5

commit 3a28e547034fe8859fa18560beb67a5ea0bb70a5
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Oct 09 16:45:35 2018

chromium_tests: only explain why we're using package transfer once.

Bug: 754104
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Change-Id: Ic65d325112a7bbd613b4343f51f8706aa8f11346
Reviewed-on: https://chromium-review.googlesource.com/c/1270260
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.expected/builder_on_buildbot.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/dynamic_junit_test.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/generic_path_config.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/README.recipes.md
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/dynamic_gtest_fuchsia.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_custom_name.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/dynamic_gtest_on_builder.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/3a28e547034fe8859fa18560beb67a5ea0bb70a5/scripts/slave/recipes/chromium.expected/kitchen_path_config.json

Comment 35 by nedngu...@google.com, Oct 10

Blockedon: 893686

Comment 36 by jbudorick@chromium.org, Jan 16

Blocking: 922636

Comment 37 by nedngu...@google.com, Jan 16

Cc: -nednguyen@chromium.org
►

Sign in to add a comment