New issue
Advanced search Search tips

Issue 754103 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 753184



Sign in to add a comment

The go isolate client should not send 278 byte packets.

Project Member Reported by hinoka@chromium.org, Aug 10 2017

Issue description

See screenshots.  MTU is like 1500 bytes, 278 byte packets is less efficient.
 
IMG_5541.JPG
1.6 MB View Download
Screen Shot 2017-08-09 at 5.10.16 PM.png
158 KB View Download
Screen Shot 2017-08-09 at 4.25.28 PM.png
444 KB View Download

Comment 1 by hinoka@chromium.org, Aug 10 2017

Possible solution: https://chromium-review.googlesource.com/c/609532

Except it buffers the whole (compressed) file in memory and we don't actually want that.
Blocking: 753184

Comment 3 by hinoka@chromium.org, Aug 10 2017

Cc: mar...@chromium.org tandrii@chromium.org
+tandrii: if you're bored you can look at this, since it's tangentially related to an ongoing P0.  I was going to do this today and got stuck on the "proper" way to implement a goroutine safe buffered pipe.

Comment 4 by hinoka@chromium.org, Aug 11 2017

Owner: hinoka@chromium.org
Status: Started (was: Unconfirmed)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4ea6214a3d097fe419d1d49f28e79697606af3a7

commit 4ea6214a3d097fe419d1d49f28e79697606af3a7
Author: Ryan Tseng <hinoka@google.com>
Date: Fri Aug 11 01:43:00 2017

Bump luci-go

74e11da8 isolatedclient: Wrap the output pipe with a bufio.Writer
54c3d655 tokenserver: Log generated OAuth token grants to BigQuery.
0a74f8a6 tokenserver: Disable usage of delegation tokens for OAuth token grants.
35da694d tokenserver: Implement MintOAuthTokenViaGrant RPC.
e2184ed2 scheduler: stop using taskDefWrapper in public configs.
3337aa00 [scheduler]: ACLs phase 3 - require ACLs specs for each Job/Trigger.
5139ec72 [luci_config] Replace proccache with LRU.
918cc42b [server/auth] Export MemoryCache.
f084fa20 [server/auth] Define types for function signatures
ae956245 [lru] Update, notably expiration.
edf44980 scheduler: make disabled jobs not visible.
2920e17b scheduler: warn if old taskWrapper used in scheduler.cfg.

Bug:  754103 
Change-Id: Ib216336d6c0ee96dce207fc97ea45f14405d9fc5
Reviewed-on: https://chromium-review.googlesource.com/610686
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/4ea6214a3d097fe419d1d49f28e79697606af3a7/DEPS

Comment 6 by hinoka@chromium.org, Aug 11 2017

Looking better (try job)
https://luci-milo.appspot.com/buildbot/tryserver.chromium.win/win_chromium_rel_ng/510057
Screen Shot 2017-08-10 at 7.45.15 PM.png
423 KB View Download

Comment 8 by hinoka@chromium.org, Aug 21 2017

Status: Fixed (was: Started)

Sign in to add a comment