The go isolate client should not send 278 byte packets. |
|||||
Issue descriptionSee screenshots. MTU is like 1500 bytes, 278 byte packets is less efficient.
,
Aug 10 2017
,
Aug 10 2017
+tandrii: if you're bored you can look at this, since it's tangentially related to an ongoing P0. I was going to do this today and got stuck on the "proper" way to implement a goroutine safe buffered pipe.
,
Aug 11 2017
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/4ea6214a3d097fe419d1d49f28e79697606af3a7 commit 4ea6214a3d097fe419d1d49f28e79697606af3a7 Author: Ryan Tseng <hinoka@google.com> Date: Fri Aug 11 01:43:00 2017 Bump luci-go 74e11da8 isolatedclient: Wrap the output pipe with a bufio.Writer 54c3d655 tokenserver: Log generated OAuth token grants to BigQuery. 0a74f8a6 tokenserver: Disable usage of delegation tokens for OAuth token grants. 35da694d tokenserver: Implement MintOAuthTokenViaGrant RPC. e2184ed2 scheduler: stop using taskDefWrapper in public configs. 3337aa00 [scheduler]: ACLs phase 3 - require ACLs specs for each Job/Trigger. 5139ec72 [luci_config] Replace proccache with LRU. 918cc42b [server/auth] Export MemoryCache. f084fa20 [server/auth] Define types for function signatures ae956245 [lru] Update, notably expiration. edf44980 scheduler: make disabled jobs not visible. 2920e17b scheduler: warn if old taskWrapper used in scheduler.cfg. Bug: 754103 Change-Id: Ib216336d6c0ee96dce207fc97ea45f14405d9fc5 Reviewed-on: https://chromium-review.googlesource.com/610686 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> [modify] https://crrev.com/4ea6214a3d097fe419d1d49f28e79697606af3a7/DEPS
,
Aug 11 2017
Looking better (try job) https://luci-milo.appspot.com/buildbot/tryserver.chromium.win/win_chromium_rel_ng/510057
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a37b1027fc39f44f38bcfe3823ba1af95909e6f2 commit a37b1027fc39f44f38bcfe3823ba1af95909e6f2 Author: Ryan Tseng <hinoka@google.com> Date: Fri Aug 11 21:22:10 2017 Roll isolate binaries to pick up GS uploader fixes Corresponds to infra/infra@4ea6214a3d097fe419d1d49f28e79697606af3a7 Built here: https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-precise-64/8550 https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-win-64/8697 https://luci-milo.appspot.com/buildbot/chromium.infra/infra-continuous-mac-10.10-64/7807 Bug: 754103 Change-Id: If1081a812d7b1039ffb1dce8e434dede1b3d928f Reviewed-on: https://chromium-review.googlesource.com/611616 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#493860} [modify] https://crrev.com/a37b1027fc39f44f38bcfe3823ba1af95909e6f2/tools/luci-go/linux64/isolate.sha1 [modify] https://crrev.com/a37b1027fc39f44f38bcfe3823ba1af95909e6f2/tools/luci-go/mac64/isolate.sha1 [modify] https://crrev.com/a37b1027fc39f44f38bcfe3823ba1af95909e6f2/tools/luci-go/win64/isolate.exe.sha1
,
Aug 21 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hinoka@chromium.org
, Aug 10 2017