Incorrect return value in CopyTexImage |
||
Issue descriptionDuring I looked at CopyTexImage related code to investigate Issue 710673 , I found some implementations' return value may be not right. I think if CopyTexImage is not implemented or doesn't meet some conditions, it should return false not true. But StreamTexture::CopyTexImage and GLImageStub::CopyTexImage don't follow it.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f878841370d32a95296a3455a381c5ec4bf3f4e commit 2f878841370d32a95296a3455a381c5ec4bf3f4e Author: Jiajia Qin <jiajia.qin@intel.com> Date: Thu Aug 10 01:59:35 2017 Fixed the incorrect return value If CopyTexImage is not implemented or doesn't meet some conditions, it should return false not true. Bug: 754099 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifc3e3be25fd502c6156917d2242c742531d44a57 Reviewed-on: https://chromium-review.googlesource.com/607714 Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#493223} [modify] https://crrev.com/2f878841370d32a95296a3455a381c5ec4bf3f4e/gpu/ipc/service/stream_texture_android.cc [modify] https://crrev.com/2f878841370d32a95296a3455a381c5ec4bf3f4e/ui/gl/gl_image_stub.cc
,
Oct 24 2017
Mark it fixed since no further work needs to do. |
||
►
Sign in to add a comment |
||
Comment 1 by kbr@chromium.org
, Aug 10 2017Status: Assigned (was: Untriaged)