Issue 754098 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	█ ranj@chromium.org Last visit > 30 days ago
Closed:	Aug 2017
Cc:	hanxi@chromium.org
Components:	Mobile>WebAPKs
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug
M-62

Short-circuit browser chooser dialog if only one browser supports webapks

Project Member Reported by yfried...@chromium.org, Aug 10 2017

Issue description

Grace made a good observation that it's not worth showing the browser selection dialog if only one browser can launch it.

Should also update https://docs.google.com/document/d/1wgqlKEQZWrdcGHx4CTAJyGYP43noXuYEgzi24z1BA_o/edit#heading=h.e8ce5gcz9jxf and test plan accordingly

Ran, can you take a look and ask Xi if you have q's.

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efc2d8debc8b8fbc15076cae8ca039c9ea3a7f0a

commit efc2d8debc8b8fbc15076cae8ca039c9ea3a7f0a
Author: Ran Ji <ranj@chromium.org>
Date: Thu Aug 17 18:22:57 2017

Skip browser selection dialog if only one browser can launch it.

Bug:  754098 
Change-Id: I33ae3d6bef7c3a72e1de933def9ab2341fde07f8
Reviewed-on: https://chromium-review.googlesource.com/614147
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495234}
[modify] https://crrev.com/efc2d8debc8b8fbc15076cae8ca039c9ea3a7f0a/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/WebApkUtilsTest.java
[modify] https://crrev.com/efc2d8debc8b8fbc15076cae8ca039c9ea3a7f0a/chrome/android/webapk/shell_apk/shell_apk_version.gni
[modify] https://crrev.com/efc2d8debc8b8fbc15076cae8ca039c9ea3a7f0a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkUtils.java

Comment 2 Deleted

Comment 3 by ranj@chromium.org, Aug 17 2017

Status: Assigned (was: Fixed)

Comment 4 by yfried...@chromium.org, Aug 31 2017

Ping: please update the docs/test plan so we can close this out

Comment 5 by ranj@chromium.org, Aug 31 2017

Status: Fixed (was: Assigned)

►

Issue 754098 link

Issue metadata

Short-circuit browser chooser dialog if only one browser supports webapks

Issue description

Comment 1 by bugdroid1@chromium.org, Aug 17 2017

Comment 1 Deleted

Comment 2 Deleted

Comment 3 by ranj@chromium.org, Aug 17 2017

Comment 3 Deleted

Comment 4 by yfried...@chromium.org, Aug 31 2017

Comment 4 Deleted

Comment 5 by ranj@chromium.org, Aug 31 2017

Comment 5 Deleted

Sign in to add a comment