New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 754097 link

Starred by 1 user
Status: Fixed
Owner:
khorimoto@chromium.org
Closed: Aug 2017
Cc:
█ jlklein@chromium.org
█ lesliewatkins@chromium.org
khorimoto@chromium.org
jhawkins@chromium.org
hansberry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

DisconnectTetheringRequest not sent when user logs out

Project Member Reported by khorimoto@chromium.org, Aug 10 2017 
This is because the logout flow is synchronous, but sending a BLE message is asynchronous.

The fix would likely involve setting a flag, then when the login screen loads, inspecting the flag and sending the message.

Note that even though the message is sent, the phone will disable its hotspot automatically after a period if inactivity.

Currently, not setting this as M-61. We may bump this in priority later.

Comment 1 by khorimoto@chromium.org, Aug 16 2017 

Note that this situation also occurs when there is an active tether session when the Tether (Mobile data) setting is disabled.

Comment 2 by khorimoto@chromium.org, Aug 29 2017

Labels: -Pri-3 M-61 OS-Chrome Pri-2
Owner: khorimoto@chromium.org
Status: Started (was: Untriaged)
Upping the priority since the situation I mentioned in comment #1 is kind of common; it is expected that users will sometimes disable Instant Tethering or turn off Bluetooth/Wi-Fi while a tether session is in use.

This solution will also *try* to send a disconnect message on logout, but it may or may not succeed depending on how long it takes to send the message.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d96af20ab51519c4b335c1486f4d73eb36472361

commit d96af20ab51519c4b335c1486f4d73eb36472361
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Aug 31 00:39:03 2017

[CrOS Tether] Add handling for asychronous shutdowns.

Previously, any shutdown flow that was asynchronous could not complete.
Now, asynchronous tasks continue as long as TetherService is alive.

This CL also changes Initializer from being a singleton to being owned
by TetherService for clarity.

Bug:  754097 , 672263
Change-Id: I5e83669b3988ac63e737bbc53e4e097a8a550f39
Reviewed-on: https://chromium-review.googlesource.com/642124
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498697}
[modify] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chrome/browser/chromeos/tether/tether_service.h
[modify] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chromeos/components/tether/BUILD.gn
[add] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chromeos/components/tether/disconnect_tethering_request_sender.cc
[add] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chromeos/components/tether/disconnect_tethering_request_sender.h
[add] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chromeos/components/tether/fake_disconnect_tethering_request_sender.cc
[add] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chromeos/components/tether/fake_disconnect_tethering_request_sender.h
[add] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chromeos/components/tether/fake_initializer.cc
[add] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chromeos/components/tether/fake_initializer.h
[modify] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chromeos/components/tether/initializer.cc
[modify] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chromeos/components/tether/initializer.h
[add] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chromeos/components/tether/initializer_impl.cc
[add] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chromeos/components/tether/initializer_impl.h
[rename] https://crrev.com/d96af20ab51519c4b335c1486f4d73eb36472361/chromeos/components/tether/initializer_impl_unittest.cc

Comment 4 by khorimoto@chromium.org, Aug 31 2017

Labels: Merge-Request-61
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 31 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 4 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by ketakid@google.com, Aug 31 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to m61.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 31 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3

commit 303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Aug 31 03:20:55 2017

[CrOS Tether] Add handling for asychronous shutdowns.

Previously, any shutdown flow that was asynchronous could not complete.
Now, asynchronous tasks continue as long as TetherService is alive.

This CL also changes Initializer from being a singleton to being owned
by TetherService for clarity.

TBR=khorimoto@google.com

(cherry picked from commit d96af20ab51519c4b335c1486f4d73eb36472361)

Bug:  754097 , 672263
Change-Id: I5e83669b3988ac63e737bbc53e4e097a8a550f39
Reviewed-on: https://chromium-review.googlesource.com/642124
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498697}
Reviewed-on: https://chromium-review.googlesource.com/644068
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1026}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chrome/browser/chromeos/tether/tether_service.h
[modify] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chromeos/components/tether/BUILD.gn
[add] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chromeos/components/tether/disconnect_tethering_request_sender.cc
[add] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chromeos/components/tether/disconnect_tethering_request_sender.h
[add] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chromeos/components/tether/fake_disconnect_tethering_request_sender.cc
[add] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chromeos/components/tether/fake_disconnect_tethering_request_sender.h
[add] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chromeos/components/tether/fake_initializer.cc
[add] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chromeos/components/tether/fake_initializer.h
[modify] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chromeos/components/tether/initializer.cc
[modify] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chromeos/components/tether/initializer.h
[add] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chromeos/components/tether/initializer_impl.cc
[add] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chromeos/components/tether/initializer_impl.h
[rename] https://crrev.com/303d9e2ccf10fbffbb00110aeabc0a9588c9e8d3/chromeos/components/tether/initializer_impl_unittest.cc

Comment 8 by khorimoto@chromium.org, Aug 31 2017

Status: Fixed (was: Started)

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 10 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment