New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754095 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Infobar dismisses after redirect

Project Member Reported by mdjones@chromium.org, Aug 10 2017

Issue description

After logging in to a website, the 'save password' infobar will appear and immediately disappear. Infobar logic should trigger dismissal when a page navigates, but not during a redirect (which is what this login should be).
 

Comment 1 by klo...@chromium.org, Aug 10 2017

FYI, this works as expected on Windows. The inforbar stays across redirect.

On Android, the issue exists in all the channels.

Comment 2 by klo...@chromium.org, Aug 10 2017

Cc: mariakho...@chromium.org thildebr@chromium.org
Labels: -Pri-3 M-61 Pri-1
Summary: Infobar dismisses after redirect (was: Infobar dismisses after redirect from login)
Hmm, it seems this affects Instant App prompt infobar too.

Make sure you have instant app enabled on the device through "Google" settings.

Change search engine in Chrome Beta (M60) to non-Google so that you won't get instant app link in SRP. e.g. use yahoo.com for testing.

Search "buzzfeed tasty" in the omnibox and click on the link for "www.buzzfeed.com > tasty" in the SRP.

You should see the infobar flash.

As this is treated as user ignore the infobar, all the following encounter of the link will always load in Chrome.


Project Member

Comment 3 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/885e2ac5ae23ba1fbc31051bcf1cde28b38e0259

commit 885e2ac5ae23ba1fbc31051bcf1cde28b38e0259
Author: Troy Hildebrandt <thildebr@chromium.org>
Date: Sat Aug 12 00:21:55 2017

Fix instant apps banners immediately disappearing.

Compares the URL the instant app banner was launched on with the current
WebContents URL to ensure we're not mistakenly dismissing banners on the
same page they were launched.

This check occurs before we use the general InfoBar ShouldExpire(),
which was using the NavigationDetails to see if this was the same page,
which is untrue on a redirect.

TBR=pkasting@chromium.org

Bug: 754095, 733733 
Change-Id: Iabc2b307b909c553e985d7a2fc5ed5f50ace6bb0
Reviewed-on: https://chromium-review.googlesource.com/612112
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493894}
[modify] https://crrev.com/885e2ac5ae23ba1fbc31051bcf1cde28b38e0259/chrome/browser/android/instantapps/instant_apps_infobar_delegate.cc
[modify] https://crrev.com/885e2ac5ae23ba1fbc31051bcf1cde28b38e0259/chrome/browser/android/instantapps/instant_apps_infobar_delegate.h
[modify] https://crrev.com/885e2ac5ae23ba1fbc31051bcf1cde28b38e0259/components/infobars/core/infobar_delegate.h

Owner: thildebr@chromium.org
Status: Assigned (was: Available)
Troy and I discussed this and he will work on a general fix for infobars.

Sign in to add a comment