Unused ash icon: ash/resources/vector_icons/system_menu_accessibility_large_cursor.icon |
|||
Issue descriptionThe accessibility menu in the system tray used to have an icon for the Large Cursor option, but that icon no longer shows now that it's part of the "Additional settings" list, as of https://codereview.chromium.org/2771963002. Is it intended that the Large Cursor option in the tray menu not have an icon? Asking because the icons at //ash/resources/vector_icons/system_menu_accessibility_large_cursor.icon and ash/resources/vector_icons/system_menu_accessibility_large_cursor.1x.icon seem to be unused. These would be referred to by the generated constant kSystemMenuAccessibilityLargeIcon, which was used when the icons were added: https://codereview.chromium.org/2343603003. Min, can you check whether these icon files can be deleted now?
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/983ea9f9ba35b8cb5e81a7c77963c953abb091f0 commit 983ea9f9ba35b8cb5e81a7c77963c953abb091f0 Author: MinChen <minch@chromium.org> Date: Mon Aug 21 20:52:03 2017 Remove system_menu_accessibility_large_cursor.icon Bug: 754092 Test: Builds locally Change-Id: I78b18ff173fba6824c0ba73ed7a29e3fea7df963 Reviewed-on: https://chromium-review.googlesource.com/621454 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#496055} [modify] https://crrev.com/983ea9f9ba35b8cb5e81a7c77963c953abb091f0/ash/resources/vector_icons/BUILD.gn [delete] https://crrev.com/1d35fd821c93bb9d89acfe88d98f55e1f2dbe97f/ash/resources/vector_icons/system_menu_accessibility_large_cursor.1x.icon [delete] https://crrev.com/1d35fd821c93bb9d89acfe88d98f55e1f2dbe97f/ash/resources/vector_icons/system_menu_accessibility_large_cursor.icon
,
Aug 21 2017
,
Jan 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by minch@chromium.org
, Aug 19 2017