Unused ash icon: shelf_voice_interaction.icon |
||||
Issue descriptionIcons shelf_voice_interaction.icon and shelf_voice_interaction.1x.icon in //ash/resources/vector_icons seem to be unused. This icon is referred to by the generated constant kShelfVoiceInteractionIcon which was used in ash/shelf/voice_interaction_overlay.cc. Xiaohui, the history of that file and its reverts is confusing... can you check whether the icon can be removed now?
,
Aug 11 2017
I used a hacky shell script: https://gist.github.com/mgiuffrida/b2b33b3e786d4bb94c1de85c57cac999
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3da797da009db70094c759499c8f82f0279f1d40 commit 3da797da009db70094c759499c8f82f0279f1d40 Author: Xiaohui Chen <xiaohuic@google.com> Date: Fri Aug 11 18:20:59 2017 Remove shelf_voice_interaction.icon BUG= 754089 TEST=builds locally Change-Id: Ic60bd7b948b5bd74fa496fe521c393ec50c5714b Reviewed-on: https://chromium-review.googlesource.com/611001 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#493817} [modify] https://crrev.com/3da797da009db70094c759499c8f82f0279f1d40/ash/resources/vector_icons/BUILD.gn [delete] https://crrev.com/23d97e814e35244de00d300515d2d3fbaa4ec10c/ash/resources/vector_icons/shelf_voice_interaction.1x.icon [delete] https://crrev.com/23d97e814e35244de00d300515d2d3fbaa4ec10c/ash/resources/vector_icons/shelf_voice_interaction.icon
,
Aug 11 2017
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e9a76a8e9479ab3cfd11fa0d6800207a1d9f34b commit 6e9a76a8e9479ab3cfd11fa0d6800207a1d9f34b Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Mon Aug 14 18:16:10 2017 Remove shelf_voice_interaction.icon BUG= 754089 TEST=builds locally TBR=xiaohuic@google.com (cherry picked from commit 3da797da009db70094c759499c8f82f0279f1d40) Change-Id: Ic60bd7b948b5bd74fa496fe521c393ec50c5714b Reviewed-on: https://chromium-review.googlesource.com/611001 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#493817} Reviewed-on: https://chromium-review.googlesource.com/614122 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#536} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/6e9a76a8e9479ab3cfd11fa0d6800207a1d9f34b/ash/resources/vector_icons/BUILD.gn [delete] https://crrev.com/796b39766c9e8bf89941628d028f87df93f57e4e/ash/resources/vector_icons/shelf_voice_interaction.1x.icon [delete] https://crrev.com/796b39766c9e8bf89941628d028f87df93f57e4e/ash/resources/vector_icons/shelf_voice_interaction.icon
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by xiaoh...@chromium.org
, Aug 10 2017