Handle ZX_ERROR_SHOULD_WAIT response to zx_channel_write() in Mojo IPC |
||
Issue descriptionFuchsia's mx_channel_write() does not currently implement flow-control, so will never return MX_ERROR_SHOULD_WAIT (see https://fuchsia.atlassian.net/browse/MG-894). When the platform is updated to implement that, we should update the Mojo ChannelFuchsia implementation to perform appropriate buffering, or error-out, as appropriate.
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/676b5fae19bd233e4cce1479d631e421fec9e7b1 commit 676b5fae19bd233e4cce1479d631e421fec9e7b1 Author: Wez <wez@chromium.org> Date: Wed Jun 20 22:34:08 2018 [mojo] Release() sent handles regardless of zx_channel_write() result. Fuchsia recently changed the zx_channel_write() API to always consume the supplied handles, by default, regardless of whether the call succeeds in transferring them to the peer process. Update the mojo::edk::Channel::Write() implementation to account for the new semantics. Bug: 854458 , 754084, 740791 Change-Id: I27f78a09ff8bf2aaf94ac571678d4c2259b48b10 Reviewed-on: https://chromium-review.googlesource.com/1108970 Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#569053} [modify] https://crrev.com/676b5fae19bd233e4cce1479d631e421fec9e7b1/mojo/edk/system/channel_fuchsia.cc
,
Jan 10
Fuchsia bug ZX-1972 appears to be the new tracking bug for channel back-pressure. |
||
►
Sign in to add a comment |
||
Comment 1 by w...@chromium.org
, Aug 10 2017