New issue
Advanced search Search tips

Issue 754071 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

IPH : Device back button doesn't dismiss the IPH bubble

Project Member Reported by shaktisahu@chromium.org, Aug 9 2017

Issue description

Probably add a static method that will keep track of all the bubbles and call the method from onBackPressed().
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d013ba1d118e12de14e02c115417dfdfb925c831

commit d013ba1d118e12de14e02c115417dfdfb925c831
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Thu Aug 10 00:17:46 2017

In-product-help : Back button should dismiss IPH bubble

The in-product-help message gets dismissed only on touch. But if the
device back button is pressed and chrome navigates to the previous page,
the bubble is still there. I think the bubble should be dismissed in
that case.

Bug:  754071 
Change-Id: I311784d87759040bb7bb3c8ba076d84d80792eda
Reviewed-on: https://chromium-review.googlesource.com/588109
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493187}
[modify] https://crrev.com/d013ba1d118e12de14e02c115417dfdfb925c831/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/d013ba1d118e12de14e02c115417dfdfb925c831/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/d013ba1d118e12de14e02c115417dfdfb925c831/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/TextBubble.java

Status: Fixed (was: Started)
Labels: -Pri-3 M-62 Pri-2

Sign in to add a comment