New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 754069 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

When Tethering is prohibited, quick settings still displays "Mobile data"

Project Member Reported by khorimoto@chromium.org, Aug 9 2017

Issue description

Repro steps:
1) Disable tethering by policy (prefs::kInstantTetheringAllowed is false).
2) Open quick settings.
3) Open network quick settings.

Expected:
Since tethering is disabled by policy, no "Mobile data" section appears.

Actual:
Mobile data section appears, and the toggle is disabled. When you click the toggle, it turns on for a moment, then turns off.

The fix should be to hide this section from quick settings when tethering is prohibited.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a00d22cf659638ae730a6b7ea7075f3be4183d83

commit a00d22cf659638ae730a6b7ea7075f3be4183d83
Author: Leslie Watkins <lesliewatkins@chromium.org>
Date: Thu Aug 10 18:21:57 2017

Remove Mobile Data section from system tray if Tether is prohibited.

Bug:  754069 , 672263
Change-Id: I5f30b891d3612006370a8df6a832582927359dc6
Reviewed-on: https://chromium-review.googlesource.com/609592
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493469}
[modify] https://crrev.com/a00d22cf659638ae730a6b7ea7075f3be4183d83/ash/system/network/network_list.cc

Labels: Merge-Request-61
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d88a5c05fa4f56e5d3f72929c4eb7d5806b824ea

commit d88a5c05fa4f56e5d3f72929c4eb7d5806b824ea
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Aug 10 21:27:00 2017

Remove Mobile Data section from system tray if Tether is prohibited.

TBR=lesliewatkins@chromium.org

(cherry picked from commit a00d22cf659638ae730a6b7ea7075f3be4183d83)

Bug:  754069 , 672263
Change-Id: I5f30b891d3612006370a8df6a832582927359dc6
Reviewed-on: https://chromium-review.googlesource.com/609592
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493469}
Reviewed-on: https://chromium-review.googlesource.com/611138
Cr-Commit-Position: refs/branch-heads/3163@{#463}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/d88a5c05fa4f56e5d3f72929c4eb7d5806b824ea/ash/system/network/network_list.cc

Status: Fixed (was: Started)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment