Implement NamedPlatformHandles for Mojo EDK under Fuchsia, or compile them out |
||||||
Issue descriptionIt's not obvious how to support NamedPlatformHandles under Fuchsia; we should decide whether we need them, and based on that either implement something, or remove the not-implemented stubs from the build.
,
Aug 18 2017
,
Aug 20
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 20
Scheduling for us to compile-out the NamedPlatformHandle code & tests on Fuchsia, rather than implementing, or filtering-out tests.
,
Oct 16
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff0c00a64ef29cba7a8f3bb9b84d13a2ad390b3b commit ff0c00a64ef29cba7a8f3bb9b84d13a2ad390b3b Author: Wez <wez@chromium.org> Date: Tue Oct 16 18:14:39 2018 [Fuchsia] Remove test cases for named Mojo channels. We don't implemented Mojo named channels under Fuchsia, so remove those test cases. Bug: 754038 Change-Id: Iac1d282d69fd972e3efa26db412f0ffcb4afe993 Reviewed-on: https://chromium-review.googlesource.com/c/1282723 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#600047} [modify] https://crrev.com/ff0c00a64ef29cba7a8f3bb9b84d13a2ad390b3b/mojo/core/multiprocess_message_pipe_unittest.cc [modify] https://crrev.com/ff0c00a64ef29cba7a8f3bb9b84d13a2ad390b3b/mojo/core/test/multiprocess_test_helper.cc [modify] https://crrev.com/ff0c00a64ef29cba7a8f3bb9b84d13a2ad390b3b/mojo/core/test/multiprocess_test_helper.h [modify] https://crrev.com/ff0c00a64ef29cba7a8f3bb9b84d13a2ad390b3b/testing/buildbot/filters/fuchsia.mojo_unittests.filter
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e459d99f5ceb5b766538299ec934dfbcadf8bf3 commit 2e459d99f5ceb5b766538299ec934dfbcadf8bf3 Author: Wez <wez@chromium.org> Date: Wed Oct 24 17:59:15 2018 [Fuchsia] Remove Mojo NamedPlatformChannel under Fuchsia. We have neither a use for, nor an implementation of, named platform channels under Fuchsia, so remove the APIs and NamedPlatformChannel handle type entirely under that platform. Bug: 754038 Change-Id: I85319f7b2df2e897e1fd34046911a2a11d5f4a20 Reviewed-on: https://chromium-review.googlesource.com/c/1288900 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#602392} [modify] https://crrev.com/2e459d99f5ceb5b766538299ec934dfbcadf8bf3/content/browser/child_process_launcher_helper.cc [modify] https://crrev.com/2e459d99f5ceb5b766538299ec934dfbcadf8bf3/content/browser/child_process_launcher_helper.h [modify] https://crrev.com/2e459d99f5ceb5b766538299ec934dfbcadf8bf3/content/browser/child_process_launcher_helper_fuchsia.cc [modify] https://crrev.com/2e459d99f5ceb5b766538299ec934dfbcadf8bf3/mojo/core/invitation_unittest.cc [modify] https://crrev.com/2e459d99f5ceb5b766538299ec934dfbcadf8bf3/mojo/core/test/multiprocess_test_helper.cc [modify] https://crrev.com/2e459d99f5ceb5b766538299ec934dfbcadf8bf3/mojo/public/cpp/platform/BUILD.gn [delete] https://crrev.com/be9cde4790e7a70ea8b80503b83fdca1ea3f1b7f/mojo/public/cpp/platform/named_platform_channel_fuchsia.cc [modify] https://crrev.com/2e459d99f5ceb5b766538299ec934dfbcadf8bf3/mojo/public/cpp/system/tests/invitation_unittest.cc
,
Oct 24
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by w...@chromium.org
, Aug 9 2017