Harmony - close firefox before importing dialog (ImportLockDialogView) |
||||||||||
Issue descriptionI can't find a mock for this dialog, so I'm giving this to bettes@
,
Aug 23 2017
,
Sep 5 2017
,
Sep 5 2017
,
Sep 19 2017
Assigning to pbos@ as a starter Harmony bug
,
Sep 20 2017
Sorry for the mix-up. Correction to #1 Title strings: Sentence case, not title case Button strings: WAI.
,
Sep 20 2017
For verbosity, button strings are not WAI on Windows. They are title case regardless instead of depending on platform.
,
Sep 20 2017
Thanks for the clarification! Comment 7 is correct, casing for buttons is determined by the OS so they are not WAI on Windows.
,
Sep 21 2017
The code for this screenshot is now up for review. We can't easily fix the dialog placement as this dialog belongs to the profile importer process and not the browser process.
,
Sep 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/408022ea045cdf7361f58666f7b19d05f9409955 commit 408022ea045cdf7361f58666f7b19d05f9409955 Author: Peter Boström <pbos@chromium.org> Date: Sat Sep 23 00:47:23 2017 Harmonize close-Firefox dialog. * Adds conditional title/non-title case for button. * Makes dialog title sentence cased. * Sets dialog size to desired 448px under Harmony (400px without it). This does not snap the dialog in the Chromium window as this dialog is spawned in a separate process and making it modal is too complicated to be worth the effort. BUG= chromium:754034 R=bsep@chromium.org Change-Id: Ief78ae5b87cbfde7ac900041e6166b33d7a513d7 Reviewed-on: https://chromium-review.googlesource.com/676533 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#503921} [modify] https://crrev.com/408022ea045cdf7361f58666f7b19d05f9409955/chrome/app/generated_resources.grd [modify] https://crrev.com/408022ea045cdf7361f58666f7b19d05f9409955/chrome/app/resources/locale_settings.grd [modify] https://crrev.com/408022ea045cdf7361f58666f7b19d05f9409955/chrome/browser/ui/views/harmony/chrome_layout_provider.cc [modify] https://crrev.com/408022ea045cdf7361f58666f7b19d05f9409955/chrome/browser/ui/views/harmony/chrome_layout_provider.h [modify] https://crrev.com/408022ea045cdf7361f58666f7b19d05f9409955/chrome/browser/ui/views/harmony/harmony_layout_provider.cc [modify] https://crrev.com/408022ea045cdf7361f58666f7b19d05f9409955/chrome/browser/ui/views/importer/import_lock_dialog_view.cc [modify] https://crrev.com/408022ea045cdf7361f58666f7b19d05f9409955/chrome/browser/ui/views/importer/import_lock_dialog_view.h
,
Sep 24 2017
This is checked in and should be available in Canary on Monday (if you want to play around with it before giving a nod). The steps to get this dialog up are: (0. Install Firefox) 1. Open Firefox 2. Open Chrome Canary 3. Go to chrome://settings 4. Click something like "import settings", I think it's one of the top 3 items. 5. Select Mozilla Firefox, and import everything. Since Firefox is already running this dialog should pop up. Since it's out of process getting it to block input to Chrome or trace the browser window would require more work. I think this current UI state is OK for launch, if you agree I'd like to either mark it as fixed or lower the priority.
,
Oct 10 2017
+ This seems to operate as an app modal, not a tab-modal as expected? Meaning it's not attached to the omnibox and instead its own window. + Mac version is missing Title casing on the title string + string overhaul for all platforms as follows. MAC: Close <Firefox> To finish importing, close all <Firefox> windows. [Try Again] [Cancel] OTHERS: Close <Firefox> To finish importing, close all <Firefox> windows. [Try again] [Cancel]
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b89087dad601cb5da9585b479d59ea0e3abf45c0 commit b89087dad601cb5da9585b479d59ea0e3abf45c0 Author: Peter Boström <pbos@chromium.org> Date: Fri Oct 20 01:56:21 2017 Update UI text for ImportLockDialog. Simplifies the dialog text and adds title case for titles and buttons. Bug: chromium:754034 Change-Id: I906d415998a8008e3a6555f72539c4d01204b477 Reviewed-on: https://chromium-review.googlesource.com/729496 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#510293} [modify] https://crrev.com/b89087dad601cb5da9585b479d59ea0e3abf45c0/chrome/app/chromium_strings.grd [modify] https://crrev.com/b89087dad601cb5da9585b479d59ea0e3abf45c0/chrome/app/generated_resources.grd
,
Oct 20 2017
bettes@: Title case + text should now be correct as well as the string overhaul, we can't make the dialog tab modal without significant work (this runs in an external process).
,
Oct 26 2017
PTAL, it's expected not to anchor :( because it's running in another process, but the rest should be correct in Canary.
,
Oct 30 2017
,
Oct 30 2017
Note to self: String is only updated in chromium not google chrome -> not visible on canary. This string doesn't mention Chrome anymore and should be moved to generated_resources.grd.
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65bd80c66133880fdb3714564a31898fecc005ef commit 65bd80c66133880fdb3714564a31898fecc005ef Author: Peter Boström <pbos@chromium.org> Date: Tue Oct 31 23:52:57 2017 Use generic Cancel for Firefox import dialog. Removes IDS_IMPORTER_LOCK_CANCEL as the dialog is no longer intended to be distinguished from other Cancel button labels. This specialized label caused translation confusion as it looks like it is intended to be specialized for the import dialog but is not "Cancel import" or similarly specialized content. Bug: b:68235708, chromium:754034 Change-Id: I15e35d90eafb621ce6a5d90a0e573edceae99ef1 Reviewed-on: https://chromium-review.googlesource.com/747633 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#513011} [modify] https://crrev.com/65bd80c66133880fdb3714564a31898fecc005ef/chrome/app/generated_resources.grd [modify] https://crrev.com/65bd80c66133880fdb3714564a31898fecc005ef/chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm [modify] https://crrev.com/65bd80c66133880fdb3714564a31898fecc005ef/chrome/browser/ui/views/importer/import_lock_dialog_view.cc
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57a48a06303777f91a6e84f72eae448899c6efa6 commit 57a48a06303777f91a6e84f72eae448899c6efa6 Author: Peter Boström <pbos@chromium.org> Date: Wed Nov 01 04:26:16 2017 Move import-lock dialog string to generic strings. "Close Firefox..." no longer mentions Chromium or Google Chrome so it can be used as a generic string. This fixes the current mismatch between Chromium/Google Chrome as only the former was updated for the new dialog string. Bug: chromium:754034 Change-Id: I4cfcf53057be681142ea8684a40b6b3eee33e436 Reviewed-on: https://chromium-review.googlesource.com/745310 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#513072} [modify] https://crrev.com/57a48a06303777f91a6e84f72eae448899c6efa6/chrome/app/chromium_strings.grd [modify] https://crrev.com/57a48a06303777f91a6e84f72eae448899c6efa6/chrome/app/generated_resources.grd [modify] https://crrev.com/57a48a06303777f91a6e84f72eae448899c6efa6/chrome/app/google_chrome_strings.grd
,
Nov 2 2017
This looks good to me in Canary and not just local builds now.
,
Nov 10 2017
The NextAction date has arrived: 2017-11-10
,
Dec 20 2017
If we're going to continue running this as an external process, we should show the native window controls. Everything else lgtm.
,
Jan 10 2018
Showing in a native window frame is out of scope for v1. Closing since there's no more feedback. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bettes@chromium.org
, Aug 21 2017Owner: ----
Status: Available (was: Assigned)