New issue
Advanced search Search tips

Issue 754029 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug

Blocking:
issue 734791



Sign in to add a comment

Support passing of file-descriptors across //ipc and //mojo channels on Fuchsia

Project Member Reported by w...@chromium.org, Aug 9 2017

Issue description

Fuchsia's POSIX emulation layer does not currently provide the necessary APIs to support passing of file descriptors across IPC channels.

Once these APIs are available, we should add the necessary hooks to Mojo, and make sure that Chrome IPC can use them.
 

Comment 1 by w...@chromium.org, Aug 9 2017

Blocking: 734791
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92d0bbb18efb3be5f1c1b1fcc5273cb9e109bb18

commit 92d0bbb18efb3be5f1c1b1fcc5273cb9e109bb18
Author: Wez <wez@chromium.org>
Date: Thu Aug 10 05:26:06 2017

Roll Fuchsia SDK to 2c480ede6948b4134bde9c689d2a72a1ba0d1282.

This includes https://fuchsia-review.googlesource.com/c/48329, which is
a prerequisite for file-descriptor passing across Fuchsia IPC channels,
and a fix for an infrequent Fuchsia hang on startup.

TBR=scottmg

Bug: 707030,  754029 
Change-Id: I3232a4383a483a6947b266da94a9395b1c363c24
Reviewed-on: https://chromium-review.googlesource.com/609392
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493267}
[modify] https://crrev.com/92d0bbb18efb3be5f1c1b1fcc5273cb9e109bb18/DEPS

Comment 3 by w...@chromium.org, Aug 11 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf4155ae20c80519451345a344dda57cf213484a

commit cf4155ae20c80519451345a344dda57cf213484a
Author: Wez <wez@chromium.org>
Date: Wed Aug 16 21:01:14 2017

Allow file-descriptors to be passed over IPC on Fuchsia.

IPC channels only support transfer of native Fuchsia OS handles, so we
need to un-wrap POSIX file-descriptors passed by callers into the
underlying handle & type information, and have Fuchsia's MXIO re-
encapsulate those into file-descriptors at the receiver.

Bug:  754029 
Change-Id: I370480679e630e419f2ba65b30f93a2bcae7dd22
Reviewed-on: https://chromium-review.googlesource.com/611462
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494947}
[modify] https://crrev.com/cf4155ae20c80519451345a344dda57cf213484a/mojo/edk/embedder/platform_handle.cc
[modify] https://crrev.com/cf4155ae20c80519451345a344dda57cf213484a/mojo/edk/embedder/platform_handle.h
[modify] https://crrev.com/cf4155ae20c80519451345a344dda57cf213484a/mojo/edk/system/channel.cc
[modify] https://crrev.com/cf4155ae20c80519451345a344dda57cf213484a/mojo/edk/system/channel.h
[modify] https://crrev.com/cf4155ae20c80519451345a344dda57cf213484a/mojo/edk/system/channel_fuchsia.cc
[modify] https://crrev.com/cf4155ae20c80519451345a344dda57cf213484a/mojo/edk/system/core.cc
[modify] https://crrev.com/cf4155ae20c80519451345a344dda57cf213484a/mojo/edk/test/test_utils_fuchsia.cc

Comment 5 by w...@chromium.org, Aug 16 2017

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d002bfeab38191780b95bf4f8468417833266b6f

commit d002bfeab38191780b95bf4f8468417833266b6f
Author: Wez <wez@chromium.org>
Date: Tue Oct 31 19:56:22 2017

Enable ipc_tests and mojo_*_unittests on Fuchsia/ARM64 bots.

This also removes the mojo_common_unittests filter, which was no longer
required.

Bug:  772031 ,  754029 
Change-Id: Ia7e28b27319ade4762a4c803ee1c4697a0f7c1ef
Reviewed-on: https://chromium-review.googlesource.com/744581
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512921}
[modify] https://crrev.com/d002bfeab38191780b95bf4f8468417833266b6f/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/d002bfeab38191780b95bf4f8468417833266b6f/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/f7c73b691582ad2a0acf3cc9681672dae0988d13/testing/buildbot/filters/fuchsia.mojo_common_unittests.filter

Sign in to add a comment