Run gl_tests against the passthrough command decoder |
||
Issue descriptiongl_tests already accept the --use-passthrough-command-decoder flag but still fail a couple of tests. Fix/suppress the failing tests and run these tests on the bots with the --use-passthrough-command-decoder flag.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d9cc1464f836e6d8c1ab9396a48c656df153d58 commit 7d9cc1464f836e6d8c1ab9396a48c656df153d58 Author: Geoff Lang <geofflang@chromium.org> Date: Thu Aug 10 17:44:08 2017 Skip gl_tests that are expected to fail with the passthrough cmd decoder BUG= 754000 BUG= 665518 BUG= angleproject:1932 BUG= 754008 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id2a3649aaa676f8ce72a838fc7cb269a84237474 Reviewed-on: https://chromium-review.googlesource.com/608805 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#493452} [modify] https://crrev.com/7d9cc1464f836e6d8c1ab9396a48c656df153d58/gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc [modify] https://crrev.com/7d9cc1464f836e6d8c1ab9396a48c656df153d58/gpu/command_buffer/tests/gl_manager.h [modify] https://crrev.com/7d9cc1464f836e6d8c1ab9396a48c656df153d58/gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc [modify] https://crrev.com/7d9cc1464f836e6d8c1ab9396a48c656df153d58/gpu/command_buffer/tests/gl_texture_mailbox_unittest.cc
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a129458eeb588b4d47a2e5aaeb8e8f083ebf120a commit a129458eeb588b4d47a2e5aaeb8e8f083ebf120a Author: Geoff Lang <geofflang@chromium.org> Date: Thu Aug 10 17:47:19 2017 Always pass the real command line options when initializing gl_tests. This caused the validating command buffer to be created in some tests despite the --use-passthrough-cmd-decoder flag. BUG= 754008 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9c01a0d657a7324182b7a82b2805174693ee0491 Reviewed-on: https://chromium-review.googlesource.com/609267 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#493453} [modify] https://crrev.com/a129458eeb588b4d47a2e5aaeb8e8f083ebf120a/gpu/command_buffer/tests/gl_apply_screen_space_antialiasing_CHROMIUM_unittest.cc [modify] https://crrev.com/a129458eeb588b4d47a2e5aaeb8e8f083ebf120a/gpu/command_buffer/tests/gl_clear_framebuffer_unittest.cc [modify] https://crrev.com/a129458eeb588b4d47a2e5aaeb8e8f083ebf120a/gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc [modify] https://crrev.com/a129458eeb588b4d47a2e5aaeb8e8f083ebf120a/gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eefb733c920914518f269aded510206ce49376b9 commit eefb733c920914518f269aded510206ce49376b9 Author: Geoff Lang <geofflang@chromium.org> Date: Thu Aug 10 17:51:47 2017 Copy the workarounds from the context group when initializing. Each passthrough command decoder has a unique FeatureInfo to handle requested extensions but was not using the workarounds from the context group. TEST=GLTest.FeatureFlagsMatchCapabilities BUG= 754008 BUG=602688 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0d050818fed7f1982b12ea66d54bc62dad97f88b Reviewed-on: https://chromium-review.googlesource.com/608808 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#493454} [modify] https://crrev.com/eefb733c920914518f269aded510206ce49376b9/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae9aeec6fec838ca14977a01ef6e039b07ff53d3 commit ae9aeec6fec838ca14977a01ef6e039b07ff53d3 Author: Geoff Lang <geofflang@chromium.org> Date: Thu Aug 10 17:53:13 2017 Create a surface with the requested size in gl_tests. Previously, the default framebuffer emulation in the command decoder would be used but with the passthrough command decoder a surfaceless surface would be used causing validation failures whenever drawing to the default framebuffer. BUG= 754008 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia2775ffd0c85879058dde1a16ee49a5f09c148a5 Reviewed-on: https://chromium-review.googlesource.com/609323 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#493456} [modify] https://crrev.com/ae9aeec6fec838ca14977a01ef6e039b07ff53d3/gpu/command_buffer/tests/gl_manager.cc
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/062c3d87579761d0a076933afca57d841914eea8 commit 062c3d87579761d0a076933afca57d841914eea8 Author: Geoff Lang <geofflang@chromium.org> Date: Thu Aug 10 19:06:33 2017 Update tracked buffer bindings on glBindBufferBase and glBindBufferRange. When buffers are bound to the indexed binding points, they are also bound to the generic binding points. TEST=ES3MapBufferRangeTest BUG= 754008 BUG=602688 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic626961d556d155d9d1b2cf584ac57c91e7f4496 Reviewed-on: https://chromium-review.googlesource.com/609266 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#493485} [modify] https://crrev.com/062c3d87579761d0a076933afca57d841914eea8/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adbdda233f871068c0666a47a20bea37c0b08c2a commit adbdda233f871068c0666a47a20bea37c0b08c2a Author: Geoff Lang <geofflang@chromium.org> Date: Thu Aug 10 21:10:00 2017 Use a framebuffer with a depth stencil in gl_tests that require it. Some gl_tests need a depth and/or stencil buffer to pass but the options do not guarentee that one will be present. Always create one to ensure the test has consistant behaviour. BUG= 665521 BUG= 754008 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I008eed043517b017545e9dc18be0c22063300a5a Reviewed-on: https://chromium-review.googlesource.com/608809 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#493545} [modify] https://crrev.com/adbdda233f871068c0666a47a20bea37c0b08c2a/gpu/command_buffer/tests/gl_clear_framebuffer_unittest.cc [modify] https://crrev.com/adbdda233f871068c0666a47a20bea37c0b08c2a/gpu/command_buffer/tests/occlusion_query_unittest.cc
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c410511fd8072ae64adf9cca0644132fdd87ca4 commit 4c410511fd8072ae64adf9cca0644132fdd87ca4 Author: Geoff Lang <geofflang@chromium.org> Date: Fri Aug 11 14:48:43 2017 Skip TextureStorageTest.CorrectImagePixels against the passthrough cmd decoder TBR=kbr@chromium.org BUG= 754008 BUG=754710 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic77caacad06a1f9b7df9d175e912200a78d96005 Reviewed-on: https://chromium-review.googlesource.com/612101 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#493737} [modify] https://crrev.com/4c410511fd8072ae64adf9cca0644132fdd87ca4/gpu/command_buffer/tests/gl_texture_storage_unittest.cc
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49e69313995741ec8423a2f7e4a27bcb8e626773 commit 49e69313995741ec8423a2f7e4a27bcb8e626773 Author: Geoff Lang <geofflang@chromium.org> Date: Fri Aug 11 16:15:53 2017 Run gl_tests against the passthrough command decoder on Windows. BUG= 754008 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7a469312f4b269fdaf2fdb72988508fc52c405db Reviewed-on: https://chromium-review.googlesource.com/608818 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#493768} [modify] https://crrev.com/49e69313995741ec8423a2f7e4a27bcb8e626773/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/49e69313995741ec8423a2f7e4a27bcb8e626773/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/49e69313995741ec8423a2f7e4a27bcb8e626773/testing/buildbot/chromium.gpu.json
,
Aug 14 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 10 2017