ES3MapBufferRangeTest failing on the passthrough command decoder |
||
Issue descriptionThe TransformFeedback and GetBufferParameteriv sub-tests are failing with the passthrough command decoder. When the passthrough command decoder maps a buffer, it modifies the map parameters which have some unexpected side-effects. Fix this.
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/79f7104ab9aa7777c0531bc6333160e7f45d9e50 commit 79f7104ab9aa7777c0531bc6333160e7f45d9e50 Author: Geoff Lang <geofflang@chromium.org> Date: Tue Aug 15 14:28:28 2017 Validate that transform feedback buffers are not mapped. Mapping a buffer that is bound for active transform feedback or starting transform feedback on a mapped buffer is undefined behaviour under section 2.10.3.2 of the ES 3.0 spec "Effects of Mapping Buffers on Other GL Commands". The spec suggests that an error is generated in this case. TEST=ES3MapBufferRangeTest.TransformFeedback BUG= 754000 Change-Id: I613defd07cc1a4348682d992cda61cc898936720 Reviewed-on: https://chromium-review.googlesource.com/614483 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/79f7104ab9aa7777c0531bc6333160e7f45d9e50/src/libANGLE/validationES3.cpp [modify] https://crrev.com/79f7104ab9aa7777c0531bc6333160e7f45d9e50/src/libANGLE/validationES2.cpp [modify] https://crrev.com/79f7104ab9aa7777c0531bc6333160e7f45d9e50/src/libANGLE/validationES2.h [modify] https://crrev.com/79f7104ab9aa7777c0531bc6333160e7f45d9e50/src/libANGLE/validationES.cpp
,
Aug 15 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/057981388d74ee578dd07067e3e4bd058eb57679 commit 057981388d74ee578dd07067e3e4bd058eb57679 Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Tue Aug 15 16:11:55 2017 Roll skia/third_party/externals/angle2/ 78ed6cd9e..79f7104ab (1 commit) https://chromium.googlesource.com/angle/angle.git/+log/78ed6cd9ea00..79f7104ab9aa $ git log 78ed6cd9e..79f7104ab --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep skia/third_party/externals/angle2 BUG= 754000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE TBR=bsalomon@google.com Change-Id: I3a31a134e11ebd57193516c8844ad78502a8ec5f Reviewed-on: https://skia-review.googlesource.com/34601 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> [modify] https://crrev.com/057981388d74ee578dd07067e3e4bd058eb57679/DEPS
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ca6d3986a6b083bedf39ae49a780fb84e2ca426 commit 4ca6d3986a6b083bedf39ae49a780fb84e2ca426 Author: Geoff Lang <geofflang@chromium.org> Date: Tue Aug 15 17:18:43 2017 Roll ANGLE 9b11ea4..79f7104 https://chromium.googlesource.com/angle/angle.git/+log/9b11ea4..79f7104 BUG= 754000 TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ib31e9600874bef9adff7259ea7fa4fc84a8f8b2c Reviewed-on: https://chromium-review.googlesource.com/615030 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#494423} [modify] https://crrev.com/4ca6d3986a6b083bedf39ae49a780fb84e2ca426/DEPS
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab96828eabf07121bafb0573b46ce56dfba9d34f commit ab96828eabf07121bafb0573b46ce56dfba9d34f Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Tue Aug 15 19:10:53 2017 Roll src/third_party/skia/ 634624a18..057981388 (1 commit) https://skia.googlesource.com/skia.git/+log/634624a1850b..057981388d74 $ git log 634624a18..057981388 --date=short --no-merges --format='%ad %ae %s' 2017-08-15 skia-deps-roller Roll skia/third_party/externals/angle2/ 78ed6cd9e..79f7104ab (1 commit) Created with: roll-dep src/third_party/skia BUG= 754000 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: Iad8ff2eafd7983a73f9511cf62159f8396572327 Reviewed-on: https://chromium-review.googlesource.com/615581 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#494480} [modify] https://crrev.com/ab96828eabf07121bafb0573b46ce56dfba9d34f/DEPS
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd8dfe9049b597af4568c15e9c1654e17d81937f commit bd8dfe9049b597af4568c15e9c1654e17d81937f Author: Geoff Lang <geofflang@chromium.org> Date: Tue Aug 15 20:06:59 2017 Fix the returned buffer access flags when they are internally modified. TEST=TransformFeedback.GetBufferParameteriv BUG= 754000 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I30d76f41a3f0b2927717933bb3335580a4020368 Reviewed-on: https://chromium-review.googlesource.com/614053 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#494515} [modify] https://crrev.com/bd8dfe9049b597af4568c15e9c1654e17d81937f/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc [modify] https://crrev.com/bd8dfe9049b597af4568c15e9c1654e17d81937f/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h [modify] https://crrev.com/bd8dfe9049b597af4568c15e9c1654e17d81937f/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc [modify] https://crrev.com/bd8dfe9049b597af4568c15e9c1654e17d81937f/gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc
,
Aug 15 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 10 2017