New issue
Advanced search Search tips

Issue 753992 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7% regression in dromaeo.domcoremodify at 491808:491890

Project Member Reported by primiano@chromium.org, Aug 9 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=753992

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=589aeabfc6471ae4f988620bcc496aeafa48addb6efad0167d6b72a4a8b193d2


Bot(s) for this bug's original alert(s):

chromium-rel-win7-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 10 2017

Cc: mlippautz@chromium.org
Owner: mlippautz@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author mlippautz@chromium.org ===

Hi mlippautz@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Michael Lippautz
  Commit : 3adb54462e091b6e93199d471f731fbae00d3f55
  Date   : Thu Aug 03 20:31:00 2017
  Subject: [wrapper-tracing] Cache wrapper tracing status in ThreadState

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : dromaeo.domcoremodify
  Metric       : dom/dom
  Change       : 2.16% | 732.632537949 -> 716.817947309

Revision             Result                  N
chromium@491807      732.633 +- 18.0313      6      good
chromium@491828      739.313 +- 18.1551      6      good
chromium@491829      742.888 +- 13.9185      6      good
chromium@491830      719.428 +- 5.34691      6      bad       <--
chromium@491831      717.072 +- 17.5323      9      bad
chromium@491834      722.013 +- 20.0829      9      bad
chromium@491839      719.278 +- 14.6704      9      bad
chromium@491849      713.388 +- 10.4303      6      bad
chromium@491890      716.818 +- 8.21803      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests dromaeo.domcoremodify

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8971703031978161120


For feedback, file a bug with component Speed>Bisection
Cc: -mlippautz@chromium.org
Components: Blink>Bindings
Status: WontFix (was: Assigned)
This is WAI. It allows us to move forward with incremental marking (tracing). The CL adds an early bailout check which is necessary for any followup work.

The follow up CL already improved blink_perf.parser* between 10-40% (blink_perf.parser in https://chromeperf.appspot.com/group_report?rev=492014). 
Labels: Performance-Tradeoff
Labels: -Performance-Tradeoff Performance-NewBaseline

Sign in to add a comment