New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753989 link

Starred by 1 user
Status: Fixed
Owner:
█ chenwilliam@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
l...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: [infra] modifying eslintignore'd files should not trigger clang format

Project Member Reported by l...@chromium.org, Aug 9 2017 
Clang format is currently run from 'presubmit.py' on all affected files in front_end/ or scripts/ that end in *.js.

This includes '.eslintrc.js', which should not be clang formatted.  We should have clang format filter out files listed in .eslintignore.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15d9337b02dd1348584085ad3244fd99823f726e

commit 15d9337b02dd1348584085ad3244fd99823f726e
Author: Will Chen <chenwilliam@chromium.org>
Date: Wed Dec 27 18:28:38 2017

DevTools: do not format eslintignore'd files in PRESUBMIT

DevTools has a convention where third-party modules are not linted by
eslint, and also shouldn't be formatted by clang-format. This re-uses
the .eslintignore list to create a blacklist for clang-format.

This removes the npm run format command because it wouldn't have the
blacklist logic.

Bug:  753989 
Change-Id: I54564938aba2b098690ecf028765021b9f2ace63
Reviewed-on: https://chromium-review.googlesource.com/843235
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526231}
[modify] https://crrev.com/15d9337b02dd1348584085ad3244fd99823f726e/third_party/WebKit/Source/devtools/.eslintignore
[modify] https://crrev.com/15d9337b02dd1348584085ad3244fd99823f726e/third_party/WebKit/Source/devtools/PRESUBMIT.py
[modify] https://crrev.com/15d9337b02dd1348584085ad3244fd99823f726e/third_party/WebKit/Source/devtools/package.json

Comment 2 by chenwilliam@chromium.org, Dec 27 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment