codebase vs -Wenum-compare-switch |
|||||
Issue description
new warning, fires at least here:
../../third_party/protobuf/src/google/protobuf/extension_set_heavy.cc:495:14: error: comparison of two values with different enumeration types ('FieldDescriptor::Type' and 'google::protobuf::internal::WireFormatLite::FieldType') [-Werror,-Wenum-compare-switch]
case WireFormatLite::TYPE_MESSAGE:
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/protobuf/src/google/protobuf/extension_set_heavy.cc:494:14: error: comparison of two values with different enumeration types ('FieldDescriptor::Type' and 'google::protobuf::internal::WireFormatLite::FieldType') [-Werror,-Wenum-compare-switch]
case WireFormatLite::TYPE_GROUP:
^~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/protobuf/src/google/protobuf/extension_set_heavy.cc:493:14: error: comparison of two values with different enumeration types ('FieldDescriptor::Type' and 'google::protobuf::internal::WireFormatLite::FieldType') [-Werror,-Wenum-compare-switch]
case WireFormatLite::TYPE_BYTES:
^~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/protobuf/src/google/protobuf/extension_set_heavy.cc:492:14: error: comparison of two values with different enumeration types ('FieldDescriptor::Type' and 'google::protobuf::internal::WireFormatLite::FieldType') [-Werror,-Wenum-compare-switch]
case WireFormatLite::TYPE_STRIN
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/203d085a0f6989b0cb4a2a6e461f5439bfa0285f commit 203d085a0f6989b0cb4a2a6e461f5439bfa0285f Author: Nico Weber <thakis@chromium.org> Date: Wed Aug 09 21:39:11 2017 Disable new -Wenum-compare-switch on the tot bots. Bug: 753944 , 753973 Change-Id: I813ce64b4db8bdef88e633a1b363eafccc8bd026 Reviewed-on: https://chromium-review.googlesource.com/608851 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Reviewed-by: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#493150} [modify] https://crrev.com/203d085a0f6989b0cb4a2a6e461f5439bfa0285f/build/config/compiler/BUILD.gn
,
Oct 10 2017
thakis@: If there is no further update to be done on this issue,please close this issue since fix has been landed. Thank you!
,
Oct 10 2017
The issue has been suppressed by that cl; the bug is still open for the real fix. How did you find this bug? There's no need to triage random bugs :-)
,
Oct 17
I'm interested in this.
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/eac96e77c3858434763f21710937b757b4ed7491 commit eac96e77c3858434763f21710937b757b4ed7491 Author: Takuto Ikuta <tikuta@chromium.org> Date: Wed Oct 17 08:12:22 2018 Use correct enum for BUILTIN and BYTECODE_HANDLER Bug: chromium:753973 Change-Id: Ib30bd11ebabfd364d6cee6d31b11c01744e13520 Reviewed-on: https://chromium-review.googlesource.com/c/1286389 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#56713} [modify] https://crrev.com/eac96e77c3858434763f21710937b757b4ed7491/src/snapshot/builtin-deserializer.cc
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a9af7c26db71edb4036de51af624fe9bc5da04b commit 1a9af7c26db71edb4036de51af624fe9bc5da04b Author: Takuto Ikuta <tikuta@chromium.org> Date: Thu Oct 18 09:52:52 2018 Remove -Wno-enum-compare-switch flag This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=haraken@chromium.org Bug: 753973 Change-Id: Ife13d645bede991ae8959759be878ed5bdf3733e Reviewed-on: https://chromium-review.googlesource.com/c/1288156 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#600707} [modify] https://crrev.com/1a9af7c26db71edb4036de51af624fe9bc5da04b/content/child/webthemeengine_impl_android.cc
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36e087c444a9c0d1abc7a57d87e79f4184cca661 commit 36e087c444a9c0d1abc7a57d87e79f4184cca661 Author: Takuto Ikuta <tikuta@chromium.org> Date: Thu Oct 18 14:38:43 2018 Remove -Wno-enum-compare-switch flag This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=sdefresne@chromium.org Bug: 753973 Change-Id: Ia8531202caddd46a45169eae9b5b8af77585ab80 Reviewed-on: https://chromium-review.googlesource.com/c/1288173 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#600758} [modify] https://crrev.com/36e087c444a9c0d1abc7a57d87e79f4184cca661/components/sync_wifi/wifi_security_class.cc
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91716fd1d1dadece3d5fd40388cb63ffa8382584 commit 91716fd1d1dadece3d5fd40388cb63ffa8382584 Author: Takuto Ikuta <tikuta@chromium.org> Date: Fri Oct 19 06:09:45 2018 A part of split CL to remove -Wno-enum-compare-switch flag I will remove -Wno-enum-compare-switch flag to block incorrect enum type comparison. To enable the warning let me fix the current codebase. This CL is a part of effort. https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 753973 Change-Id: If4e27fa4d1977a57080090c5a2275de64cee626f Reviewed-on: https://chromium-review.googlesource.com/c/1288155 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#601064} [modify] https://crrev.com/91716fd1d1dadece3d5fd40388cb63ffa8382584/ppapi/shared_impl/private/ppb_char_set_shared.cc
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a135f4d37a72b080c97a5ed7d5404f03a2ab7978 commit a135f4d37a72b080c97a5ed7d5404f03a2ab7978 Author: Takuto Ikuta <tikuta@chromium.org> Date: Fri Oct 19 09:02:56 2018 Remove -Wno-enum-compare-switch flag This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=jkrcal@chromium.org Bug: 753973 Change-Id: Id1503ebb271fd19492e49d98e821412d67cbc5aa Reviewed-on: https://chromium-review.googlesource.com/c/1288171 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601083} [modify] https://crrev.com/a135f4d37a72b080c97a5ed7d5404f03a2ab7978/components/autofill/core/browser/webdata/autofill_profile_sync_bridge.cc
,
Oct 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e58852bade049c98caa158f4520c26a88f12ead commit 1e58852bade049c98caa158f4520c26a88f12ead Author: Takuto Ikuta <tikuta@chromium.org> Date: Sat Oct 20 00:24:25 2018 Remove -Wno-enum-compare-switch flag This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=imcheng@chromium.org Bug: 753973 Change-Id: I37354ffed6f228bb85ac3d05a19bdf6bf606b6f3 Reviewed-on: https://chromium-review.googlesource.com/c/1288154 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601369} [modify] https://crrev.com/1e58852bade049c98caa158f4520c26a88f12ead/components/cast_channel/cast_auth_util_unittest.cc
,
Oct 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d7167b4c91a02c1c3a1c91677c4d5d72583d8ac commit 5d7167b4c91a02c1c3a1c91677c4d5d72583d8ac Author: Takuto Ikuta <tikuta@chromium.org> Date: Sat Oct 20 03:16:28 2018 Remove -Wno-enum-compare-switch flag This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=dpranke@chromium.org Bug: 753973 Change-Id: Ie5be77df8c85eff62c9e0bb7bee0e20bbc4c367a Reviewed-on: https://chromium-review.googlesource.com/c/1288172 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601397} [modify] https://crrev.com/5d7167b4c91a02c1c3a1c91677c4d5d72583d8ac/build/config/compiler/BUILD.gn [modify] https://crrev.com/5d7167b4c91a02c1c3a1c91677c4d5d72583d8ac/third_party/android_protobuf/BUILD.gn
,
Oct 20
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by thakis@chromium.org
, Aug 9 2017