New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 753949 link

Starred by 2 users
Status: Assigned
Owner:
█ ben@chromium.org
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Content embedders as unique services.

Project Member Reported by ben@chromium.org, Aug 9 2017 
Content embedders should be unique services, rather than merging API surface with services provided by content. As a consequence, much of (all of?) content's various broker pipes should be considered private implementation details rather than being exposed via content/public.

See https://groups.google.com/a/chromium.org/d/msg/services-dev/WIBTutb40mk/syPVH-TJBAAJ for more detail.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c

commit e25ef85d8efe10fba7ab34e82b5ccca507c93c5c
Author: Ben Goodger <ben@chromium.org>
Date: Fri Aug 11 00:17:50 2017

Expose a chrome service from ChromeContentBrowserClient.

This repurposes the previously ChromeOS-only service impl and makes it available on all platforms.

This service now exposes StartupMetricsHost to chrome/renderer, rather than content_browser (via overlay).

Bug: 753949
Change-Id: I12689ccabc3e8895ba9df68318b1238d63074d6b
Reviewed-on: https://chromium-review.googlesource.com/600515
Commit-Queue: Ben Goodger <ben@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493610}
[modify] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/app/chrome_manifest.json
[modify] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/browser/BUILD.gn
[modify] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/browser/browser_process_platform_part_chromeos.cc
[modify] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/browser/chrome_content_renderer_manifest_overlay.json
[add] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/browser/chrome_service.cc
[add] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/browser/chrome_service.h
[modify] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/browser/chromeos/launchable.cc
[add] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/browser/chromeos/launchable.h
[modify] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/common/BUILD.gn
[add] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/common/constants.mojom
[modify] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/services/ui/public/cpp/input_devices/input_device_controller.cc
[modify] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/services/ui/public/cpp/input_devices/input_device_controller.h
[modify] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/services/ui/service.cc
[modify] https://crrev.com/e25ef85d8efe10fba7ab34e82b5ccca507c93c5c/services/ui/service.h
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03c39c2239b147ad3ed246853ef4b006d7b9922d

commit 03c39c2239b147ad3ed246853ef4b006d7b9922d
Author: Ben Goodger <ben@chromium.org>
Date: Thu Oct 26 23:45:37 2017

Move Spellcheck onto the Chrome service.

R=rockot@chromium.org,tsepez@chromium.org

Bug: 753949
Change-Id: Ifef4b58b47df41f69692cc6098f6f5c0631c34f8
Reviewed-on: https://chromium-review.googlesource.com/614422
Commit-Queue: Ben Goodger <ben@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512022}
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/android_webview/common/OWNERS
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/android_webview/renderer/DEPS
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/android_webview/renderer/aw_content_renderer_client.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/android_webview/renderer/aw_content_renderer_client.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/app/chrome_manifest.json
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/chrome_service.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/chrome_service.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/chrome_site_per_process_browsertest.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/spellchecker/spell_check_host_impl.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/spellchecker/spell_check_host_impl.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/spellchecker/spellcheck_factory.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/spellchecker/spellcheck_factory.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/spellchecker/spellcheck_message_filter_platform_mac.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/spellchecker/spellcheck_service.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/spellchecker/spellcheck_service.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/browser/spellchecker/spellcheck_service_browsertest.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/chrome/test/base/chrome_render_view_test.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/hunspell_engine.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/hunspell_engine.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/platform_spelling_engine.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/spellcheck.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/spellcheck.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/spellcheck_language.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/spellcheck_language.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/spellcheck_multilingual_unittest.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/spellcheck_panel.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/spellcheck_panel.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/spellcheck_provider.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/spellcheck_provider.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/spellcheck_provider_test.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/spellcheck_unittest.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/components/spellcheck/renderer/spelling_engine.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/content/public/browser/content_browser_client.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/content/public/browser/render_process_host.h
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/services/service_manager/public/cpp/BUILD.gn
[add] https://crrev.com/03c39c2239b147ad3ed246853ef4b006d7b9922d/services/service_manager/public/cpp/local_interface_provider.h
►

Sign in to add a comment