New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 753944 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Sign in to add a comment

roll clang again

Project Member Reported by thakis@chromium.org, Aug 9 2017

Issue description

r310410 for  issue 749805  and hopefully  issue 753032 
r310330 for  issue 753909 

Currently blocked on -Wenum-compare (https://reviews.llvm.org/D36526)
 
Wenum-compare-switch landed in r310521. Now we can disable that on the tot bots and see if they cycle green. I'll give that a go.
Blocking: 753909
Cc: ruiu@google.com
We also likely want to wait for an lld change that adds --icf=none to lld (see internal thread "I want to disable ICF for a server-side binary"). ruiu, please update this bug with an llvm revision number once you landed that flag
r310382 to make avail attrib not make symbols visible
Blocking: 742563
We also likely want to wait for a fix for PR34056, sounds like that's imminent.

Comment 6 by ruiu@google.com, Aug 9 2017

I've just added --icf=none to lld in http://reviews.llvm.org/rL310526.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/203d085a0f6989b0cb4a2a6e461f5439bfa0285f

commit 203d085a0f6989b0cb4a2a6e461f5439bfa0285f
Author: Nico Weber <thakis@chromium.org>
Date: Wed Aug 09 21:39:11 2017

Disable new -Wenum-compare-switch on the tot bots.

Bug:  753944 , 753973 
Change-Id: I813ce64b4db8bdef88e633a1b363eafccc8bd026
Reviewed-on: https://chromium-review.googlesource.com/608851
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493150}
[modify] https://crrev.com/203d085a0f6989b0cb4a2a6e461f5439bfa0285f/build/config/compiler/BUILD.gn

r310534 for  issue 742563  (that's the thing I said we should wait for in comment 5). Sounds like we can give it a shot once the tot bots have cycled green.

Comment 9 by thakis@chromium.org, Aug 10 2017

trying to build binaries at https://chromium-review.googlesource.com/c/610363
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60031f7bbd86172a18cd4150ba7004b59593c73b

commit 60031f7bbd86172a18cd4150ba7004b59593c73b
Author: Nico Weber <thakis@chromium.org>
Date: Fri Aug 11 18:19:10 2017

Roll clang 309984:310580.

Ran `tools/clang/scripts/upload_revision.py 310580`.

BUG= 753944 

Change-Id: I1c1857de33bf6c6368c83c18838d49bf92036b58
Reviewed-on: https://chromium-review.googlesource.com/610363
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493815}
[modify] https://crrev.com/60031f7bbd86172a18cd4150ba7004b59593c73b/build/config/compiler/BUILD.gn
[modify] https://crrev.com/60031f7bbd86172a18cd4150ba7004b59593c73b/tools/clang/scripts/update.py

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d3d8140989b31a392735887adfb0f253faceaea

commit 5d3d8140989b31a392735887adfb0f253faceaea
Author: Nico Weber <thakis@chromium.org>
Date: Fri Aug 11 20:42:05 2017

Revert "Roll clang 309984:310580."

This reverts commit 60031f7bbd86172a18cd4150ba7004b59593c73b.

Reason for revert: Broke iOS/arm64 builds,  crbug.com/754829 

Original change's description:
> Roll clang 309984:310580.
> 
> Ran `tools/clang/scripts/upload_revision.py 310580`.
> 
> BUG= 753944 
> 
> Change-Id: I1c1857de33bf6c6368c83c18838d49bf92036b58
> Reviewed-on: https://chromium-review.googlesource.com/610363
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#493815}

TBR=thakis@chromium.org,hans@chromium.org

Change-Id: I5148540b4d63bd2069b3747025919dd517f797b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  753944 
Reviewed-on: https://chromium-review.googlesource.com/611723
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493843}
[modify] https://crrev.com/5d3d8140989b31a392735887adfb0f253faceaea/build/config/compiler/BUILD.gn
[modify] https://crrev.com/5d3d8140989b31a392735887adfb0f253faceaea/tools/clang/scripts/update.py

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2af1673dd06e01a9adc15d34776f1100ca4e7f5c

commit 2af1673dd06e01a9adc15d34776f1100ca4e7f5c
Author: Nico Weber <thakis@chromium.org>
Date: Sat Aug 12 23:23:01 2017

Roll clang 309984:310694.

Ran `tools/clang/scripts/upload_revision.py 310694`.

BUG= 753944 
TBR=hans

Change-Id: I7e6aed0f0d65fa28c5df19523d41e06e7ea94c11
Reviewed-on: https://chromium-review.googlesource.com/612477
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493985}
[modify] https://crrev.com/2af1673dd06e01a9adc15d34776f1100ca4e7f5c/build/config/compiler/BUILD.gn
[modify] https://crrev.com/2af1673dd06e01a9adc15d34776f1100ca4e7f5c/tools/clang/scripts/update.py

Blocking: 753032
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d09279c9b7cd06cc9d1fa91c03c3a49338674041

commit d09279c9b7cd06cc9d1fa91c03c3a49338674041
Author: Nico Weber <thakis@chromium.org>
Date: Mon Aug 14 19:41:31 2017

mac: Remove workaround for a compiler bug that's now fixed.

Bug:  669240 , 735328 , 753944 
Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
Change-Id: Ia478da385744cb064da270819322abc3d8789f9c
Reviewed-on: https://chromium-review.googlesource.com/614081
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494135}
[modify] https://crrev.com/d09279c9b7cd06cc9d1fa91c03c3a49338674041/services/shape_detection/barcode_detection_impl_mac.h
[modify] https://crrev.com/d09279c9b7cd06cc9d1fa91c03c3a49338674041/services/shape_detection/text_detection_impl_mac.h
[modify] https://crrev.com/d09279c9b7cd06cc9d1fa91c03c3a49338674041/ui/base/cocoa/touch_bar_util.h

Owner: thakis@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment