Incorrect scaling value displayed when fit to page is checked |
||||||||
Issue descriptionChrome Version: 62.0.3180.0 OS: tested on Win10 but should impact all What steps will reproduce the problem? (1) Open any PDF file in Chrome (2) Print preview (3) Select fit to page (4) Change paper size What is the expected result? Scaling displayed once "Fit to Page" is checked should change with different paper sizes. What happens instead? Displayed scale value remains at "100" regardless of paper size. Current stable (60.0.3112.90) is working correctly, so bisected to https://chromium.googlesource.com/chromium/src/+log/4ca1c84c9ba5693d1cdb11e76d874193b59e11cb..52fdc03978f070e636fb9014fb59256b81a119f6 so it's likely https://codereview.chromium.org/2969383003
,
Aug 10 2017
,
Aug 10 2017
Before we approve merge to M61, please answer followings: * Is this M61 regression? Is it critical? * Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M61? * Any other important details to justify the merge. Please note M61 is already in Beta, so merge bar is very high. Thank you.
,
Aug 10 2017
Sorry, should have waited for this to land in Canary before requesting. Will ping this again tomorrow. This is an M61 regression; it works in M60 but not 61. While this does not crash the browser or create any serious problems it is a very obvious user-visible bug that occurs any time the user is printing a PDF from Print Preview. The change is also less than 1 line of code, so should be a very simple merge.
,
Aug 10 2017
No worries and thank you rbpotter@. Please update the bug with Canary result. If it looks good in Canary, I will approve the merge.
,
Aug 11 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 11 2017
Tested the issue using #62.0.3182.0 on Win 10, Mac 10.12.6, Linux Ubuntu 14.04. Observed now the scale size is changing accroding to the papaer size. Please find the screencast for the same. Hence adding Verfied labels. Thanks!!
,
Aug 11 2017
Verified Canary 62.0.3182.0 looks good on Win10.
,
Aug 11 2017
Approving merge to M61 branch 3163 based on comment #4, #7 and #8.
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a150a364b4efedc77a21131da8a8db4f0c1fc920 commit a150a364b4efedc77a21131da8a8db4f0c1fc920 Author: rbpotter <rbpotter@chromium.org> Date: Fri Aug 11 21:44:26 2017 Print Preview: Fix WebUI Event name Incorrect event name was used when registering the listener, so the event was never received. TBR=rbpotter@chromium.org (cherry picked from commit 168bd826fe11a44238a169ef953447db0c0e4841) Bug: 753942 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie58dacc705632f90857bf8fb19139d7f967e1684 Reviewed-on: https://chromium-review.googlesource.com/609093 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#493243} Reviewed-on: https://chromium-review.googlesource.com/611794 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#497} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/a150a364b4efedc77a21131da8a8db4f0c1fc920/chrome/browser/resources/print_preview/print_preview.js
,
Aug 16 2017
Tested the issue using #61.0.3163.49 on Win 10, Mac 10.12.6, Linux Ubuntu 14.04. Observed now the scale size is changing accroding to the papaer size. Please find the screencast for the same. Hence adding Verfied labels. Thanks!!
,
Aug 16 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 10 2017