New issue
Advanced search Search tips

Issue 753928 link

Starred by 1 user
Status: Fixed
Owner:
mthiesse@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

VR: Startup race when presenting leads to insecure origin warning on secure origins.

Project Member Reported by mthiesse@chromium.org, Aug 9 2017 
If the gvr delegate isn't ready before the present result is, then we fail to set that the origin is secure, leaving it marked as insecure.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/632a58cf3fa626a2e71f0df5c0e3f0ac12dbca4d

commit 632a58cf3fa626a2e71f0df5c0e3f0ac12dbca4d
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Wed Aug 09 21:36:41 2017

VR: Fix startup race incorrectly setting insecure origin.

Bug:  753928 
Change-Id: I86da5ea764e09d601846e297b029a69946ba63cb
Reviewed-on: https://chromium-review.googlesource.com/608843
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493148}
[modify] https://crrev.com/632a58cf3fa626a2e71f0df5c0e3f0ac12dbca4d/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/632a58cf3fa626a2e71f0df5c0e3f0ac12dbca4d/chrome/browser/android/vr_shell/vr_shell_delegate.h

Comment 2 by mthiesse@chromium.org, Aug 9 2017

Status: Fixed (was: Started)

Comment 3 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
►

Sign in to add a comment